From: Aisheng Dong <aisheng.dong@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Stefan Agner <stefan.agner@toradex.com>,
"arnd@arndb.de" <arnd@arndb.de>, Abel Vesa <abel.vesa@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"allison@lohutok.net" <allison@lohutok.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"info@metux.net" <info@metux.net>,
Leonard Crestez <leonard.crestez@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module
Date: Thu, 18 Jun 2020 01:58:51 +0000 [thread overview]
Message-ID: <AM6PR04MB4966B94CFAE642E6AF5AEF79809B0@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB3PR0402MB39163BC04E4E5F4F6A22F6D4F59A0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
> From: Anson Huang <anson.huang@nxp.com>
> Sent: Wednesday, June 17, 2020 8:27 PM
>
>
> > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock
> > driver as module
> >
> > > From: Anson Huang <Anson.Huang@nxp.com>
> > > Sent: Tuesday, June 9, 2020 3:32 PM
> > >
> > > There are more and more requirements of building SoC specific
> > > drivers as modules, add support for building SCU clock driver as
> > > module to meet the requirement.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > Changes since V1:
> > > - add ARCH_MXC to build dependency to avoid build fail on x86 arch;
> > > - move clk-lpcg-scu.c change in to this patch.
> > > ---
> > > drivers/clk/imx/Kconfig | 4 ++--
> > > drivers/clk/imx/Makefile | 5 ++---
> > > drivers/clk/imx/clk-lpcg-scu.c | 1 +
> > > drivers/clk/imx/clk-scu.c | 5 +++++
> > > 4 files changed, 10 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> > > db0253f..ded0643 100644
> > > --- a/drivers/clk/imx/Kconfig
> > > +++ b/drivers/clk/imx/Kconfig
> > > @@ -5,8 +5,8 @@ config MXC_CLK
> > > def_bool ARCH_MXC
> > >
> > > config MXC_CLK_SCU
> > > - bool
> > > - depends on IMX_SCU
> >
> > Keep this line as it is
> >
> > > + tristate "IMX SCU clock"
> >
> > i.MX SCU Clock core driver
> >
> > > + depends on ARCH_MXC && IMX_SCU
> > >
> > > config CLK_IMX8MM
> > > bool "IMX8MM CCM Clock Driver"
> > > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile
> > > index 928f874..1af8cff 100644
> > > --- a/drivers/clk/imx/Makefile
> > > +++ b/drivers/clk/imx/Makefile
> > > @@ -21,9 +21,8 @@ obj-$(CONFIG_MXC_CLK) += \
> > > clk-sscg-pll.o \
> > > clk-pll14xx.o
> > >
> > > -obj-$(CONFIG_MXC_CLK_SCU) += \
> > > - clk-scu.o \
> > > - clk-lpcg-scu.o
> > > +mxc-clk-scu-objs += clk-scu.o clk-lpcg-scu.o
> > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o
> >
> > Like i.MX pinctrl, I'm not sure if it's really necessary to build core
> > libraries as modules. Probably the simplest way is only building
> > platform drivers part as module. And leave those core libraries built in kernel.
> > This may make the code a bit cleaner.
> >
>
> Will discuss this with Linaro guys about it, previous requirement I received is all
> SoC specific modules need to be built as module.
>
Okay. AFAIK it's not conflict.
You still make drivers into modules.
Only difference is for those common libraries part, we don't convert them into module
Which is less meaningless.
Regards
Aisheng
> Anson
next prev parent reply other threads:[~2020-06-18 1:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:32 [PATCH V2 0/9] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-09 7:32 ` [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-17 10:10 ` Aisheng Dong
2020-06-17 12:31 ` Anson Huang
2020-06-18 2:05 ` Aisheng Dong
2020-06-20 3:22 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC Anson Huang
2020-06-17 10:34 ` Aisheng Dong
2020-06-17 12:36 ` Anson Huang
2020-06-18 3:09 ` Aisheng Dong
2020-06-18 3:18 ` Anson Huang
2020-06-18 3:58 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-17 10:44 ` Aisheng Dong
2020-06-17 12:26 ` Anson Huang
2020-06-18 1:58 ` Aisheng Dong [this message]
2020-06-20 3:27 ` Stephen Boyd
2020-06-23 3:42 ` Aisheng Dong
2020-06-23 8:34 ` Stephen Boyd
2020-06-23 9:00 ` Aisheng Dong
2020-06-24 0:57 ` Stephen Boyd
2020-06-24 2:19 ` Aisheng Dong
2020-06-24 2:36 ` Anson Huang
2020-06-24 2:59 ` Aisheng Dong
2020-06-24 22:43 ` Stephen Boyd
2020-06-29 7:04 ` Dong Aisheng
2020-06-29 8:19 ` Arnd Bergmann
2020-06-30 3:01 ` Aisheng Dong
2020-06-30 4:41 ` Anson Huang
[not found] ` <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>
2020-07-02 6:15 ` Anson Huang
2020-06-24 7:46 ` Arnd Bergmann
2020-06-24 9:18 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 4/9] clk: imx: Support building i.MX common " Anson Huang
2020-06-22 7:05 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 5/9] clk: imx8mm: Support module build Anson Huang
2020-06-09 7:32 ` [PATCH V2 6/9] clk: imx8mn: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 7/9] clk: imx8mp: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 8/9] clk: imx8mq: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 9/9] clk: imx8qxp: " Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB4966B94CFAE642E6AF5AEF79809B0@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=allison@lohutok.net \
--cc=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).