From: Dong Aisheng <dongas86@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Abel Vesa <abel.vesa@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
Stefan Agner <stefan.agner@toradex.com>,
allison@lohutok.net, Arnd Bergmann <arnd@arndb.de>,
Fabio Estevam <festevam@gmail.com>,
gregkh <gregkh@linuxfoundation.org>,
info@metux.net, Sascha Hauer <kernel@pengutronix.de>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Michael Turquette <mturquette@baylibre.com>,
oleksandr.suvorov@toradex.com,
Sascha Hauer <s.hauer@pengutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Shawn Guo <shawnguo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
yuehaibing@huawei.com, dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module
Date: Mon, 29 Jun 2020 15:04:40 +0800 [thread overview]
Message-ID: <CAA+hA=RB3H_EqCMpCuide7WDqddaZu5=LmihU1pZaCPM8b8zng@mail.gmail.com> (raw)
In-Reply-To: <159303858063.62212.4991053028281879719@swboyd.mtv.corp.google.com>
On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Aisheng Dong (2020-06-23 19:59:09)
> > > > > > - bool
> > > > > > - def_bool ARCH_MXC
> > > > > > + tristate "IMX clock"
> > > > > > + depends on ARCH_MXC
> > > > > >
> > > > > > But user can still set MXC_CLK to be m, either via make menuconfig
> > > > > > or
> > > > > defconfig.
> > > > >
> > > > > Isn't that what we want?
> > > >
> > > > No, if user set MXC_CLK to m, the build will break for i.MX6&7.
> > > >
> > > > > Why does ARCH_MXC being enabled mandate that it is builtin? Is some
> > > > > architecture level code calling into the clk driver?
> > > >
> > > >
> > > > It's mainly because there's no Kconfig options for i.MX6 &7 clock drivers.
> > > > It just reuses ARCH config CONFIG_SOC_XXX which can only be y.
> > > > e.g.
> > > > obj-$(CONFIG_SOC_IMX6Q) += clk-imx6q.o
> > > > obj-$(CONFIG_SOC_IMX6SL) += clk-imx6sl.o
> > > > obj-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o
> > > > obj-$(CONFIG_SOC_VF610) += clk-vf610.o ..
> > > >
> > > > If setting MXC_CLK to m, the platform clock drivers will fail to build
> > > > due to miss to find symbols defined in the common clock library by
> > > > CONFIG_MXC_CLK.
> > > > So we have to avoid users to be able to config MXC_CLK to m for i.MX6&7.
> > > > Only depends on ARCH_MXC mean user still can set it to m.
> > >
> > > I think for i.MX6/7, although MXC_CLK is tristate, but it is selected by
> > > ARCH_MXC which is always "y", so MXC_CLK can ONLY be "y" even it is explicitly
> > > set to "m" in imx_v6_v7_defconfig file. So that means MXC_CLK can ONLY
> > > support built-in for i.MX6/7 SoCs, and that is what we want?
> > >
> >
> > Yes, I'm trying to explain to Stephen why we have to select MXC_CLK in ARCH_MXC
> > And what issues we will met if not select it.
> >
>
> Why aren't there options to enable clk-imx6q and clk-imx6sl in the
> clk/imx/Kconfig file? Those can be bool or tristate depending on if the
> SoC drivers use CLK_OF_DECLARE or not and depend on the mxc-clk library
> and SoC config we have in the makefile today.
Yes, we can do that in clk/imx/Kconfig as follows theoretically.
config CLK_IMX6Q
bool
def_bool ARCH_MXC && ARM
select MXC_CLK
But we have totally 15 platforms that need to change.
e.g.
drivers/clk/imx/Makefile
obj-$(CONFIG_SOC_IMX1) += clk-imx1.o
obj-$(CONFIG_SOC_IMX21) += clk-imx21.o
obj-$(CONFIG_SOC_IMX25) += clk-imx25.o
obj-$(CONFIG_SOC_IMX27) += clk-imx27.o
obj-$(CONFIG_SOC_IMX31) += clk-imx31.o
obj-$(CONFIG_SOC_IMX35) += clk-imx35.o
obj-$(CONFIG_SOC_IMX5) += clk-imx5.o
obj-$(CONFIG_SOC_IMX6Q) += clk-imx6q.o
obj-$(CONFIG_SOC_IMX6SL) += clk-imx6sl.o
obj-$(CONFIG_SOC_IMX6SLL) += clk-imx6sll.o
obj-$(CONFIG_SOC_IMX6SX) += clk-imx6sx.o
obj-$(CONFIG_SOC_IMX6UL) += clk-imx6ul.o
obj-$(CONFIG_SOC_IMX7D) += clk-imx7d.o
obj-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o
obj-$(CONFIG_SOC_VF610) += clk-vf610.o
Not sure if it's really worth to do that.
The easiest way to address this issue is just select it in
arch/arm/mach-imx/Kconfig,
then no need to change those 15 clock config options or just builtin
clk libraries.
Stephen,
which one do you prefer?
Regards
Aisheng
next prev parent reply other threads:[~2020-06-29 20:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:32 [PATCH V2 0/9] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-09 7:32 ` [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-17 10:10 ` Aisheng Dong
2020-06-17 12:31 ` Anson Huang
2020-06-18 2:05 ` Aisheng Dong
2020-06-20 3:22 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC Anson Huang
2020-06-17 10:34 ` Aisheng Dong
2020-06-17 12:36 ` Anson Huang
2020-06-18 3:09 ` Aisheng Dong
2020-06-18 3:18 ` Anson Huang
2020-06-18 3:58 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-17 10:44 ` Aisheng Dong
2020-06-17 12:26 ` Anson Huang
2020-06-18 1:58 ` Aisheng Dong
2020-06-20 3:27 ` Stephen Boyd
2020-06-23 3:42 ` Aisheng Dong
2020-06-23 8:34 ` Stephen Boyd
2020-06-23 9:00 ` Aisheng Dong
2020-06-24 0:57 ` Stephen Boyd
2020-06-24 2:19 ` Aisheng Dong
2020-06-24 2:36 ` Anson Huang
2020-06-24 2:59 ` Aisheng Dong
2020-06-24 22:43 ` Stephen Boyd
2020-06-29 7:04 ` Dong Aisheng [this message]
2020-06-29 8:19 ` Arnd Bergmann
2020-06-30 3:01 ` Aisheng Dong
2020-06-30 4:41 ` Anson Huang
[not found] ` <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>
2020-07-02 6:15 ` Anson Huang
2020-06-24 7:46 ` Arnd Bergmann
2020-06-24 9:18 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 4/9] clk: imx: Support building i.MX common " Anson Huang
2020-06-22 7:05 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 5/9] clk: imx8mm: Support module build Anson Huang
2020-06-09 7:32 ` [PATCH V2 6/9] clk: imx8mn: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 7/9] clk: imx8mp: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 8/9] clk: imx8mq: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 9/9] clk: imx8qxp: " Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+hA=RB3H_EqCMpCuide7WDqddaZu5=LmihU1pZaCPM8b8zng@mail.gmail.com' \
--to=dongas86@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=allison@lohutok.net \
--cc=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).