From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87647C433DF for ; Mon, 17 Aug 2020 07:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6231120772 for ; Mon, 17 Aug 2020 07:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T4aAZgpV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgHQH5t (ORCPT ); Mon, 17 Aug 2020 03:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbgHQH5k (ORCPT ); Mon, 17 Aug 2020 03:57:40 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82BC8C061389 for ; Mon, 17 Aug 2020 00:57:40 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id v22so11540646edy.0 for ; Mon, 17 Aug 2020 00:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zyf1GnJhx3UwerNj3dj95Y5/fqE2+AsdIjPlhMtajAQ=; b=T4aAZgpVWFJ6e3KoyF+v1EA11n/u5zLqZAMoEptQat5ofVfT0SteX6ictIzYfwXtsO DdKr8M8fN37uWnqHtYInzSFGHhFVt+Bk3HGWbx20R6PsKH7tGfN7thI4ggqW//jxt4gt iYsRlG/lpYnlYduQj9H4iS5/T8nviPwdTBiU+8I4/mmhqnqPfMlgeisY0SZ4KDSKj7Lr Q/Zmi0Bp+sinhawAxgE5BIet26FkKHczPL2wEVRoOyrFVjOeeYlWDlsJulvbKtVOlysu vtBYQj+bsWRrf4R+oZt3xI6M3p0wlK2F7OzBgFIEiXk5uzgT0lOoyNsVnMbjfONjlxMx oYLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zyf1GnJhx3UwerNj3dj95Y5/fqE2+AsdIjPlhMtajAQ=; b=a82bCPHd8oqof3p8waIf2SV7CA6xVAWkhrTYcuA9EhKsJwhBWVjmOTodGMiCVE6WmE UVydU91tqfB/0rwm9Tf40ybnjO3pgnn4NPI8PknLRaDiYmvC6acatte0GmcwB9SUyWwh tznshqS13sCevECdWsHBue826rSLNbkaQAlPCfSl7jlFODpmafW8Tn3i/OWcyTLhIWBA RIE+hMZD30M4VBG2wocr/lk34w3B8DHN/+7RYZJWXAL7qxZd2dHGcroLLPzACstqJ6j+ QVjG5/PHdTu8+yg5/vVHV57LelYnemradXLUWt31SE7L70WNaBxQA9GTmipe3FAPKj8p 7fGw== X-Gm-Message-State: AOAM533yq/mYAkMy7lGgyQpSbmxPn2nEvzj0kbIEAimck6kuEa1jVa42 YcRqII0107BQ9FwuwayzgXEvPUKQ6KedofHvaqk= X-Google-Smtp-Source: ABdhPJw/eAb+81Ye7DQICKEBQsM+VZtP+LycnHlseGh4fHFy0yuTMnmXnhBtuX2IVXFeezB+kvqdH5MlEEmqlW7jFZQ= X-Received: by 2002:aa7:d983:: with SMTP id u3mr14248750eds.366.1597651059202; Mon, 17 Aug 2020 00:57:39 -0700 (PDT) MIME-Version: 1.0 References: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: From: Dong Aisheng Date: Mon, 17 Aug 2020 15:42:33 +0800 Message-ID: Subject: Re: [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support To: Dong Aisheng Cc: linux-clk , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Stephen Boyd , Michael Turquette , Shawn Guo , Fabio Estevam , dl-linux-imx , Sascha Hauer Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Gently ping... On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng wrote: > > Hi Stephen, > > This patchset addressed all your new comments. > Right now only Patch 2/3 still haven't got any R-b or A-b tags. So > still need your help to review. > All other patches already got the R-b tags. > > BTW, for [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support to parse > clocks from device tree. > It was reviewed by Rob/Shawn and you before, however, due to the legacy binding > file has been removed and changed to json format. > So this patch also updated to json format accordingly based on the > former reviewed patch > and need a re-review. > > Regards > Aisheng > > On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng wrote: > > > > This patch series is a preparation for the MX8 Architecture improvement. > > As for IMX SCU based platforms like MX8QM and MX8QXP, they are comprised > > of a couple of SS(Subsystems) while most of them within the same SS > > can be shared. e.g. Clocks, Devices and etc. > > > > However, current clock binding is using SW IDs for device tree to use > > which can cause troubles in writing the common -ss-xx.dtsi file for > > different SoCs. > > > > This patch series aims to introduce a new binding which is more close to > > hardware and platform independent and can makes us write a more general > > drivers for different SCU based SoCs. > > > > Another important thing is that on MX8, each Clock resource is associated > > with a power domain. So we have to attach that clock device to the power > > domain in order to make it work properly. Further more, the clock state > > will be lost when its power domain is completely off during suspend/resume, > > so we also introduce the clock state save&restore mechanism. > > > > It's based on latest shanw/for-next branch. > > > > The top commit is: > > 3c1a41dab7b8 Merge branch 'imx/defconfig' into for-next > > > > ChangeLog: > > v6->v7: > > * addressed all comments from Stephen > > * rebased to latest shawn/for-next > > v5->v6: > > * add scu clk unregister if add provider failed > > v4->v5: > > * Address all comments from Stephen > > v3->v4: > > * use clk-indices for LPCG to fetch each clks offset from dt > > v2->v3: > > * change scu clk into two cells binding > > * add clk pm patches to ease the understand of the changes > > v1->v2: > > * SCU clock changed to one cell clock binding inspired by arm,scpi.txt > > Documentation/devicetree/bindings/arm/arm,scpi.txt > > * Add required power domain property > > * Dropped PATCH 3&4 first, will send the updated version accordingly > > after the binding is finally determined, > > > > Dong Aisheng (11): > > dt-bindings: firmware: imx-scu: new binding to parse clocks from > > device tree > > dt-bindings: clock: imx-lpcg: add support to parse clocks from device > > tree > > clk: imx: scu: add two cells binding support > > clk: imx: scu: bypass cpu power domains > > clk: imx: scu: allow scu clk to take device pointer > > clk: imx: scu: add runtime pm support > > clk: imx: scu: add suspend/resume support > > clk: imx: imx8qxp-lpcg: add parsing clocks from device tree > > clk: imx: lpcg: allow lpcg clk to take device pointer > > clk: imx: clk-imx8qxp-lpcg: add runtime pm support > > clk: imx: lpcg: add suspend/resume support > > > > .../bindings/arm/freescale/fsl,scu.txt | 12 +- > > .../bindings/clock/imx8qxp-lpcg.yaml | 79 ++++-- > > drivers/clk/imx/clk-imx8qxp-lpcg.c | 139 +++++++++++ > > drivers/clk/imx/clk-imx8qxp.c | 136 +++++----- > > drivers/clk/imx/clk-lpcg-scu.c | 53 +++- > > drivers/clk/imx/clk-scu.c | 234 +++++++++++++++++- > > drivers/clk/imx/clk-scu.h | 56 ++++- > > include/dt-bindings/clock/imx8-lpcg.h | 14 ++ > > 8 files changed, 620 insertions(+), 103 deletions(-) > > create mode 100644 include/dt-bindings/clock/imx8-lpcg.h > > > > -- > > 2.23.0 > >