* [PATCH] clk: meson: axg-audio: improve deferral handling
@ 2021-05-20 7:31 Jerome Brunet
2021-05-20 20:18 ` Martin Blumenstingl
2021-05-26 3:11 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Jerome Brunet @ 2021-05-20 7:31 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jerome Brunet, Kevin Hilman, linux-amlogic, linux-clk, linux-kernel
Use dev_err_probe() for clock and reset resources to indicate the deferral
reason through sysfs when waiting for the resource to come up.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
This is a follow up on
https://lore.kernel.org/r/20210429090516.61085-1-jbrunet@baylibre.com
drivers/clk/meson/axg-audio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
index 7c8d02164443..bfe36bd41339 100644
--- a/drivers/clk/meson/axg-audio.c
+++ b/drivers/clk/meson/axg-audio.c
@@ -1665,8 +1665,7 @@ static int devm_clk_get_enable(struct device *dev, char *id)
clk = devm_clk_get(dev, id);
if (IS_ERR(clk)) {
ret = PTR_ERR(clk);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get %s", id);
+ dev_err_probe(dev, ret, "failed to get %s", id);
return ret;
}
@@ -1811,7 +1810,7 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
ret = device_reset(dev);
if (ret) {
- dev_err(dev, "failed to reset device\n");
+ dev_err_probe(dev, ret, "failed to reset device\n");
return ret;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: axg-audio: improve deferral handling
2021-05-20 7:31 [PATCH] clk: meson: axg-audio: improve deferral handling Jerome Brunet
@ 2021-05-20 20:18 ` Martin Blumenstingl
2021-05-24 9:37 ` Jerome Brunet
2021-05-26 3:11 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2021-05-20 20:18 UTC (permalink / raw)
To: Jerome Brunet
Cc: Neil Armstrong, Kevin Hilman, linux-amlogic, linux-clk, linux-kernel
On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> Use dev_err_probe() for clock and reset resources to indicate the deferral
> reason through sysfs when waiting for the resource to come up.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: axg-audio: improve deferral handling
2021-05-20 20:18 ` Martin Blumenstingl
@ 2021-05-24 9:37 ` Jerome Brunet
0 siblings, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2021-05-24 9:37 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Neil Armstrong, Kevin Hilman, linux-amlogic, linux-clk, linux-kernel
On Thu 20 May 2021 at 22:18, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>> Use dev_err_probe() for clock and reset resources to indicate the deferral
>> reason through sysfs when waiting for the resource to come up.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: axg-audio: improve deferral handling
2021-05-20 7:31 [PATCH] clk: meson: axg-audio: improve deferral handling Jerome Brunet
2021-05-20 20:18 ` Martin Blumenstingl
@ 2021-05-26 3:11 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-05-26 3:11 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Jerome Brunet, Kevin Hilman, linux-amlogic, linux-clk, linux-kernel
Quoting Jerome Brunet (2021-05-20 00:31:36)
> Use dev_err_probe() for clock and reset resources to indicate the deferral
> reason through sysfs when waiting for the resource to come up.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 3:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 7:31 [PATCH] clk: meson: axg-audio: improve deferral handling Jerome Brunet
2021-05-20 20:18 ` Martin Blumenstingl
2021-05-24 9:37 ` Jerome Brunet
2021-05-26 3:11 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).