From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: jbrunet@baylibre.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com
Subject: Re: [PATCH v2 0/4] clk: meson: clk-pll driver update
Date: Sun, 12 Aug 2018 20:26:53 +0200 [thread overview]
Message-ID: <CAFBinCCNY3=yo42hQUqJJzeSetLni+whtWaBZCL-MV63DDYQow@mail.gmail.com> (raw)
In-Reply-To: <20180801140053.25899-1-jbrunet@baylibre.com>
Hi Jerome,
On Wed, Aug 1, 2018 at 4:00 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> This patchset is yet another round of update to the amlogic pll driver.
>
> 1) Enable bit is added so we don't rely on the bootloader or the init
> value to enable to pll device.
> 2) Remove unnecessary CLK_GET_RATE_NOCACHE flags.
> 3) OD post dividers are removed from the pll driver. This simplify the
> driver and let us provide the clocks which exist between those
> dividers. Some device are actually using these clocks.
> 4) The rates hard coded in parameter tables are remove. Instead, we
> only rely on the parent rate and the parameters to calculate the
> output rate, which is a lot better.
>
> This series has been tested on the gxl libretech cc and axg s400.
> I did not test it on meson8b yet.
>
> Changes since v1: [0]
> - improve commit description of patch 1
> - remove unnecessary CLK_GET_RATE_NOCACHE flags.
> - add missing CLK_SET_RATE_PARENT.
>
> [0]: https://lkml.kernel.org/r/20180717095617.12240-1-jbrunet@baylibre.com
>
> Jerome Brunet (4):
> clk: meson: clk-pll: add enable bit
> clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary
> clk: meson: clk-pll: remove od parameters
> clk: meson: clk-pll: drop hard-coded rates from pll tables
for the whole series:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
as well as:
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
(tested on Meson8b / Odroid-C1, even CPU frequency scaling still works
with my out-of-tree patches)
Regards
Martin
next prev parent reply other threads:[~2018-08-12 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 14:00 [PATCH v2 0/4] clk: meson: clk-pll driver update Jerome Brunet
2018-08-01 14:00 ` [PATCH v2 1/4] clk: meson: clk-pll: add enable bit Jerome Brunet
2018-08-01 14:00 ` [PATCH v2 2/4] clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary Jerome Brunet
2018-08-01 14:00 ` [PATCH v2 3/4] clk: meson: clk-pll: remove od parameters Jerome Brunet
2018-08-01 14:00 ` [PATCH v2 4/4] clk: meson: clk-pll: drop hard-coded rates from pll tables Jerome Brunet
2018-08-12 18:26 ` Martin Blumenstingl [this message]
2018-08-27 12:59 ` [PATCH v2 0/4] clk: meson: clk-pll driver update Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCCNY3=yo42hQUqJJzeSetLni+whtWaBZCL-MV63DDYQow@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).