From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89DDC33C9E for ; Tue, 7 Jan 2020 09:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A687C21744 for ; Tue, 7 Jan 2020 09:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578390795; bh=rcKJiBOHF/a0+MDVGltwkYmA7kAiSShXv3OfBucNo/w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fVviVicJdJZyiNTRvHfZQt9MyE6Wt6qrkxqYGNX/FtRDJh6myyf1j1Blt3mgNuV1W KjFg797MhZtrq/uwlc5dzJ25Pk6aRGSNpwJJUu8sru1g/z7JPvxVhxmmViw7n3CBlA f9IPkdTlfjQqnD+VHTG4URU+bHjBMUwUylbDmZBE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727616AbgAGJxK (ORCPT ); Tue, 7 Jan 2020 04:53:10 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:37397 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbgAGJxJ (ORCPT ); Tue, 7 Jan 2020 04:53:09 -0500 Received: by mail-ot1-f68.google.com with SMTP id k14so75721552otn.4; Tue, 07 Jan 2020 01:53:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rcKJiBOHF/a0+MDVGltwkYmA7kAiSShXv3OfBucNo/w=; b=spnwUusnFCnaGf0nGyhvYIrZK7fZxpchw6XZAQvKRpfSTstjz1xbvLHYrIer0tt1NQ pOmR9iHuZCi+Xad2SBPYWR6XjJkc4WH7f3RhtWQkE6vD+CgiLwJIigIoZNqKDFrTCOi7 ekkK6FQuLloN7K5IWcCA84W2PhEU4sDup6KXC05A4Xxe9Lasl3W4GTxQgROtxvrI9bd6 q9tMJfTKCxvF+uud38NFqdU1SayNNThFi/oRzzlSbqgduMZHY3uh04R+StFmSVF4ESxl NTcdfFFqTxRKvTLoH8H8z21jlPBhA70Ue0eYGza7RPMIyHLRyx+YU+ZjKOKrdfSJXYgf EnLA== X-Gm-Message-State: APjAAAU2zApQ8IQFnvMckrK9/w5ky0goBRLpYuAYc5ANu/OU/zxkuzeR TbAhQBPYuloBuxZ1Rhvfa5fE9o92Le7TkqYwgCQ= X-Google-Smtp-Source: APXvYqyijdjeyq4HJ5FCDcI015uTWnvTRQoFeaQRgxTWy1DfLN1zgBL6llgNmNnOtPrGgkpTZXmDGjkn5Is6S8EHkt8= X-Received: by 2002:a9d:62c7:: with SMTP id z7mr111166052otk.189.1578390788841; Tue, 07 Jan 2020 01:53:08 -0800 (PST) MIME-Version: 1.0 References: <20200106045833.1725-1-masahiroy@kernel.org> In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> From: "Rafael J. Wysocki" Date: Tue, 7 Jan 2020 10:52:57 +0100 Message-ID: Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check To: Masahiro Yamada Cc: Andrew Morton , Julia Lawall , ACPI Devel Maling List , Linux ARM , linux-clk , linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c , Linux Kernel Mailing List , linux-mtd@lists.infradead.org, netdev , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, Jan 6, 2020 at 6:11 AM Masahiro Yamada wrote: > > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- Acked-by: Rafael J. Wysocki for the acpi/scan.c change, but there seems to be a typo in the subject: s/redundent/redundant/