From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7208C43331 for ; Mon, 30 Mar 2020 08:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B88DD2073B for ; Mon, 30 Mar 2020 08:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585557492; bh=BkHx8NFiQ75YGJGHV3YLzUBEEQCGCQ6ZgXds5RE21G4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=VFqiFS56eO9rEkK48neHqiI3RTwlgmXpa2ekzms8Xi/hBj+znh3cpOyQQbUf43R3l 4qO+DVCoBBCl8Us4DuDwr+w3E5tC2bTsVv0LmMnWSz7W6R5fJDHZFI2jUhaZcUg6bU lGLh6M5Eyf7SBvY6OmXWRF0Spi8AHVitNeoW+nyg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729648AbgC3IiM (ORCPT ); Mon, 30 Mar 2020 04:38:12 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:56073 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgC3IiM (ORCPT ); Mon, 30 Mar 2020 04:38:12 -0400 X-Greylist: delayed 5280 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Mar 2020 04:38:09 EDT Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 02U8bmN8026273; Mon, 30 Mar 2020 17:37:49 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 02U8bmN8026273 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1585557470; bh=PxRmu3HuDIYTqEJxiJ5PqE2LXmQuo3D9zlavzY5jVI4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=brVEPKJScKZunXMPy14SQD8gmdtXfD/Z7CL8ZRWvjqvg8UYOEXDjY45m6LQp+Upry SgIqRIt+Vbfvxsnbg1Sa4ESbah6Ht4e+ygLsb2zMtFxzxi6m+CL+3akLM9W4IRUtrC 8IrkWOugyFCF6k+q9DWaJ/RylMYkLVAXmcO1Y053y79in1DJ1SYDKl6QryZcJvymZW zhUI92s1QDExgPzlgqMqS+2VzRW+Hf/0CueUJkv89pUXdRGkEy/yT1U57PQSLpZHL5 dpuemg5XzFyFNtnhwxT9TEaThfuk/wESfJfRmQy4YDPJPK/eWz1pRIvn+23Xa8wREx iiOBT5PkS+9Hg== X-Nifty-SrcIP: [209.85.222.47] Received: by mail-ua1-f47.google.com with SMTP id r47so5951861uad.11; Mon, 30 Mar 2020 01:37:49 -0700 (PDT) X-Gm-Message-State: AGi0PuYfI1t4jOABvMJbBeheO5K31RVjKrp+v3PMdlyhGrfyx/pJ5lj8 56rX/6bnMc6mi60tJtnMdm1005lbsmAaPgRPoO8= X-Google-Smtp-Source: APiQypJeTOypTow5s/orWLiqA+luxDBNhpwR1xE86uZ7tA8NnJnWdBsJgIswlbl89EaZoapGrF/J2WDHqcRU1fH6V1M= X-Received: by 2002:a9f:28c5:: with SMTP id d63mr6911883uad.25.1585557468135; Mon, 30 Mar 2020 01:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Mon, 30 Mar 2020 17:37:11 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' To: Rob Herring Cc: DTML , Linux Kernel Mailing List , Bartosz Golaszewski , Bjorn Andersson , Brian Masney , Daniel Lezcano , "David S. Miller" , Guillaume La Roque , Hartmut Knaack , Jonathan Cameron , Kevin Hilman , Lars-Peter Clausen , Lee Jones , Liam Girdwood , Linus Walleij , Mark Brown , Mauro Carvalho Chehab , Michael Hennerich , Neil Armstrong , Peter Meerwald-Stadler , Stephen Boyd , Thomas Gleixner , Zhang Rui , dri-devel , linux-amlogic@lists.infradead.org, linux-arm-kernel , linux-arm-msm , linux-clk , "open list:GPIO SUBSYSTEM" , linux-iio@vger.kernel.org, Linux Media Mailing List , Linux PM mailing list , Networking Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Rob, On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada wrote: > > On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote: > > > > Setting 'additionalProperties: false' is frequently omitted, but is > > important in order to check that there aren't extra undocumented > > properties in a binding. > > > > Ideally, we'd just add this automatically and make this the default, but > > there's some cases where it doesn't work. For example, if a common > > schema is referenced, then properties in the common schema aren't part > > of what's considered for 'additionalProperties'. Also, sometimes there > > are bus specific properties such as 'spi-max-frequency' that go into > > bus child nodes, but aren't defined in the child node's schema. > > > > So let's stick with the json-schema defined default and add > > 'additionalProperties: false' where needed. This will be a continual > > review comment and game of wack-a-mole. > > > > Signed-off-by: Rob Herring > > --- > > > > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++ > > > You may have already queue this up, but just in case. > > Acked-by: Masahiro Yamada I take back Ack for socionext,uniphier-gpio.yaml Now "make dt_binding_check" produces a new warning. gpio@55000000: 'interrupt-parent' does not match any of the regexes: 'pinctrl-[0-9]+' This binding uses 'interrupt-parent' without 'interrupts'. Instead, the mapping of the interrupt numbers is specified by the vendor-specific property socionext,interrupt-ranges I cannot add "interrupt-parent: true" because dt-schema/meta-schemas/interrupts.yaml has "interrupt-parent: false". Is there any solution? -- Best Regards Masahiro Yamada