From: Arnd Bergmann <arnd@arndb.de>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>, Andy Duan <fugang.duan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
YueHaibing <yuehaibing@huawei.com>,
linux-clk <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
NXP Linux Team <Linux-imx@nxp.com>
Subject: Re: [PATCH V8 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits
Date: Thu, 30 Jul 2020 09:22:37 +0200 [thread overview]
Message-ID: <CAK8P3a000jKRMM9pm72mw5a1xV=NtOT6Z-H2EDS6=5165HMt5w@mail.gmail.com> (raw)
In-Reply-To: <1596067120-1193-2-git-send-email-Anson.Huang@nxp.com>
On Thu, Jul 30, 2020 at 2:03 AM Anson Huang <Anson.Huang@nxp.com> wrote:
>
> Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> instead of (1 << X) to fix below build warning reported by kernel
> test robot:
>
> drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2020-07-30 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 23:58 [PATCH V8 0/6] Support building i.MX ARMv8 platforms clock driver as module Anson Huang
2020-07-29 23:58 ` [PATCH V8 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits Anson Huang
2020-07-30 7:22 ` Arnd Bergmann [this message]
2020-07-29 23:58 ` [PATCH V8 2/6] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-07-29 23:58 ` [PATCH V8 3/6] clk: imx: Support building i.MX common clock driver as module Anson Huang
2020-07-29 23:58 ` [PATCH V8 4/6] clk: imx: Add clock configuration for ARMv7 platforms Anson Huang
2020-07-29 23:58 ` [PATCH V8 5/6] clk: imx8m: Support module build Anson Huang
2020-07-29 23:58 ` [PATCH V8 6/6] clk: imx8qxp: Support building i.MX8QXP clock driver as module Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a000jKRMM9pm72mw5a1xV=NtOT6Z-H2EDS6=5165HMt5w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).