From: Rob Herring <robh+dt@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org>,
soc@kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy
Date: Tue, 7 Jan 2020 16:20:56 -0600 [thread overview]
Message-ID: <CAL_Jsq+LduJhf_LawZ+Ofu-70J3c1L3NuqAw3_jzYpC0Gy3x0A@mail.gmail.com> (raw)
In-Reply-To: <20191220065314.237624-4-lkundrak@v3.sk>
On Fri, Dec 20, 2019 at 1:01 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> This is the PHY chip for USB HSIC on MMP3 platform.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> .../bindings/phy/marvell,mmp3-hsic-phy.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
Seems this is already in -next, but it breaks dt_binding_check.
>
> diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> new file mode 100644
> index 0000000000000..7917a95cda78d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
Dual license new bindings:
(GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2019 Lubomir Rintel <lkundrak@v3.sk>
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Marvell MMP3 HSIC PHY
> +
> +maintainers:
> + - Lubomir Rintel <lkundrak@v3.sk>
> +
> +properties:
> + compatible:
> + const: marvell,mmp3-hsic-phy
> +
> + reg:
> + maxItems: 1
> + description: base address of the device
Drop description. That's *every* 'reg' property.
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO connected to reset
> +
> + "#phy-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - "#phy-cells"
> +
> +examples:
> + - |
> + hsic-phy@f0001800 {
> + compatible = "marvell,mmp3-hsic-phy";
> + reg = <0xf0001800 0x40>;
> + reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
Examples are built now and this one doesn't. You need the include for
the define. Check with 'make dt_binding_check'.
> + #phy-cells = <0>;
> + };
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-01-07 22:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 6:53 [PATCH 1/5] Enable HSIC on MMP3 SoC Lubomir Rintel
2019-12-20 6:53 ` [PATCH 1/5] dt-bindings: marvell,mmp2: Add clock ids for the HSIC clocks Lubomir Rintel
2019-12-23 19:32 ` Stephen Boyd
2019-12-20 6:53 ` [PATCH 2/5] clk: mmp2: Add " Lubomir Rintel
2019-12-23 19:33 ` Stephen Boyd
2019-12-20 6:53 ` [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy Lubomir Rintel
2020-01-07 22:20 ` Rob Herring [this message]
2019-12-20 6:53 ` [PATCH 4/5] ARM: dts: mmp3: Add HSIC controllers Lubomir Rintel
2019-12-20 7:05 ` Lubomir Rintel
2020-01-06 19:22 ` Olof Johansson
2019-12-23 9:57 ` kbuild test robot
2019-12-20 6:53 ` [PATCH 5/5] ARM: dts: mmp3-dell-ariel: Enable the HSIC Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+LduJhf_LawZ+Ofu-70J3c1L3NuqAw3_jzYpC0Gy3x0A@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).