From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F84C32771 for ; Mon, 6 Jan 2020 09:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB38A215A4 for ; Mon, 6 Jan 2020 09:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="D1o966Mx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgAFJiR (ORCPT ); Mon, 6 Jan 2020 04:38:17 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:33822 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbgAFJiR (ORCPT ); Mon, 6 Jan 2020 04:38:17 -0500 Received: by mail-io1-f66.google.com with SMTP id z193so47937171iof.1 for ; Mon, 06 Jan 2020 01:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k2+obkL6rebOtdriVSVT+QmM5oPrNk9dBLg/jYY+wfo=; b=D1o966MxyHxQctJ7rWTwJMt3NjGv7Dvvox7er9lgSNNvWFHHGJwcWONCfWtZi6gN+G sRs4vR0DB2EcpFyAOnNBrO6Ga7QtFeR72FBTF9427T+497Qzcfm+8pl2pbBszlc9JvVQ 5lkYYgLVWA+odDpMbgsGqK5RaUIs7BmqtrPT75mjcq5Cps8QL2hw57ZZN4r24h+9vHFL a+0FUA2QZ2/EndxTc3PDJardW9IZ7lhDOn+2+dkqYDe/IvqXD733Uy0eoMyHFCObNslD T6Kj74zvZbASdqOn7QT7jqwZ2Hbx2etpk6CtUIx5rIfvpbv2lv5teqA/qj36BoqxsUw4 LIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k2+obkL6rebOtdriVSVT+QmM5oPrNk9dBLg/jYY+wfo=; b=PFOI/nE4lmzW73jO4yHhlw2J+/ValK3N0lFUadeHyCqlOkNdLpHRl4W4WUlrQ+SAjq 31PbCCiwfnqsT8Z++arzNYJz8YM3I6g1ycn+MCy/Up4x+GuC354SH8+/UByGRKsDGdQj /6EKH7QJ+l3Cxakw8VO09mMxF0/3IP/20sNeFRqhBKCv328KeVTbnIZgs51QQ89y/HTp N1rz3gkT6dsFx2wz+uwvc1BDNdAhcHVj4Jxvsl8SlRLiYqXcLUyTDJHI04v7Bvxh2sB3 Vpta+BBBYFo4TbAACHO8QHvdYYQAdz7rfB+6mzhP5q3j5yJ7bYY26VasBPPaJURYFDgS Ts4w== X-Gm-Message-State: APjAAAWeT9Sjoplv9QmvgMg53BgLawJzW2ePoI4U149DjwBGNR9GuZth Q1EQ5JB6PKCOV6NoJhNBpBsRxrPGbyTLAlDA81ZuIA== X-Google-Smtp-Source: APXvYqzE32XYz3+At4KghXnJsLBu7odv7vp28Pnk5lZat2Vp4MBrZzHnDvUV6gAXMdReOEfzJCGFp0QdxKmkLf29OSM= X-Received: by 2002:a5d:9dd9:: with SMTP id 25mr58696986ioo.287.1578303496369; Mon, 06 Jan 2020 01:38:16 -0800 (PST) MIME-Version: 1.0 References: <20200106045833.1725-1-masahiroy@kernel.org> In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> From: Bartosz Golaszewski Date: Mon, 6 Jan 2020 10:38:05 +0100 Message-ID: Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check To: Masahiro Yamada Cc: Andrew Morton , devicetree , alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, "open list:GPIO SUBSYSTEM" , netdev , Linux Kernel Mailing List , Julia Lawall , "open list:MEMORY TECHNOLOGY..." , linux-crypto@vger.kernel.org, linux-clk , Linux ARM , linux-i2c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org pon., 6 sty 2020 o 06:00 Masahiro Yamada napisa=C5= =82(a): > > 'PTR_ERR(p) =3D=3D -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) =3D=3D - error_code) > +PTR_ERR(ptr) =3D=3D - error_code > // > > Signed-off-by: Masahiro Yamada For GPIO: Acked-by: Bartosz Golaszewski