From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61408C43603 for ; Tue, 10 Dec 2019 20:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D65F20828 for ; Tue, 10 Dec 2019 20:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726500AbfLJURQ (ORCPT ); Tue, 10 Dec 2019 15:17:16 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35592 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbfLJURP (ORCPT ); Tue, 10 Dec 2019 15:17:15 -0500 Received: by mail-ot1-f68.google.com with SMTP id o9so16708334ote.2; Tue, 10 Dec 2019 12:17:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3ZOtJg/wUcW5kOXl2+mxnJ/u+/k6ol/NbX7ohcECSMA=; b=Y7/vQGri2e5Z0TpVX6mwWTA2oWvsR1tfxnJdIBXnXa0mgRd4npxkjONfnCs4+/jJ83 YGXItEUxLRMnTfu4F0rc4oAs27yNRCl66zqaVn5NL7KVaSTohsWn7RMv562WJ09NSUYz GxynOzoklgA5lRqwTGA2YyZLX8EdYE5NpxSCYmmhv6wcvoqvbI9qzVcqfQzQDBqGv7Kc AvI/+/v3D0meZ+43ZFP/1DcQiKJ9txKSssXyMtcosXCl2hvcMrF9o2n+0geLIHZbe38T B4bawFV65f1KfACCRwXiaELlK6VRDMrU84itiAJVGvlybpwJR8WuZ3L2GG7joQ9/RdKZ hifw== X-Gm-Message-State: APjAAAWYQhSxsgJkcpLhRJXiDcJVVlryIKxZDsU9KUCclDWH//QzqKZc D47dTkLdzMmpqQkQPW/iFujAp2Y7331A+2tc3bw= X-Google-Smtp-Source: APXvYqxk6jSZeRmcJmUtNHfwYqoI+imTEnVPHt5HnVw8PSLZZYAAs7vv4JxN2jO4y+f782uERdtFHGDeCPlzbw3FNIc= X-Received: by 2002:a9d:2073:: with SMTP id n106mr27288012ota.145.1576009034999; Tue, 10 Dec 2019 12:17:14 -0800 (PST) MIME-Version: 1.0 References: <20191206134202.18784-1-chris.brandt@renesas.com> <20191206134202.18784-3-chris.brandt@renesas.com> <0cbd8556-cf17-7d6b-5c12-e8d663a39cfa@cogentembedded.com> In-Reply-To: <0cbd8556-cf17-7d6b-5c12-e8d663a39cfa@cogentembedded.com> From: Geert Uytterhoeven Date: Tue, 10 Dec 2019 21:17:03 +0100 Message-ID: Subject: Re: [PATCH v2 2/6] dt-bindings: spi: Document Renesas SPIBSC bindings To: Sergei Shtylyov Cc: Chris Brandt , Mark Brown , Rob Herring , Mark Rutland , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , linux-spi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk , Mason Yang Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Sergei, On Tue, Dec 10, 2019 at 9:07 PM Sergei Shtylyov wrote: > On 12/09/2019 05:09 PM, Geert Uytterhoeven wrote: > >> Document the bindings used by the Renesas SPI bus space controller. > >> Signed-off-by: Chris Brandt > >> --- > >> v2: > >> * change to YAML format > >> * add interrupts property > >> * Used more terms directly from the hardware manual > > > > Thanks for the update! > > > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/spi/renesas,spibsc.yaml > [...] > >> +properties: > >> + compatible: > >> + oneOf: > >> + - items: > >> + - enum: > >> + - renesas,r7s72100-spibsc # RZ/A1 > >> + - renesas,r7s9210-spibsc # RZ/A2 > >> + > >> + reg: > >> + minItems: 2 > >> + maxItems: 2 > >> + items: > >> + - description: Registers > >> + - description: Memory Mapped Address Space > > > > The second one is not needed, if you would add "ranges" for the > > memory-mapped mode. > > I'm not sure we can do that. The flash bus is accessed via a window > with the high bits in the DREAR reg, even in the direct read mode... So if the FLASH is too large, you cannot access all of it without programming the high bits. However, when using XIP, you're limited to the window size anyway. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds