From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/5] clk: renesas: r8a7795: Add TMU clocks
Date: Thu, 10 Dec 2020 13:32:12 +0100 [thread overview]
Message-ID: <CAMuHMdUWAnia_cNSgsGWS7DMpj=vPzpb3NJwf-mXQAJnEwTR8Q@mail.gmail.com> (raw)
In-Reply-To: <20201209195343.803120-2-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -128,6 +128,11 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
> DEF_MOD("fdp1-2", 117, R8A7795_CLK_S2D1), /* ES1.x */
> DEF_MOD("fdp1-1", 118, R8A7795_CLK_S0D1),
> DEF_MOD("fdp1-0", 119, R8A7795_CLK_S0D1),
> + DEF_MOD("tmu4", 121, R8A7795_CLK_S0D6),
The above is correct for R-Car H3 ES2.0 and later.
On R-Car H3 ES1.x, the parent clock of TMU4 is S3D2 (datasheet rev 0.52),
so you need to add an entry to r8a7795es1_mod_reparent[].
> + DEF_MOD("tmu3", 122, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu2", 123, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu1", 124, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu0", 125, R8A7795_CLK_CP),
> DEF_MOD("scif5", 202, R8A7795_CLK_S3D4),
> DEF_MOD("scif4", 203, R8A7795_CLK_S3D4),
> DEF_MOD("scif3", 204, R8A7795_CLK_S3D4),
The rest looks good to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-12-10 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
2020-12-10 12:32 ` Geert Uytterhoeven [this message]
2020-12-09 19:53 ` [PATCH 2/5] clk: renesas: r8a7796: " Niklas Söderlund
2020-12-10 12:34 ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 3/5] clk: renesas: r8a77965: " Niklas Söderlund
2020-12-10 12:35 ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 4/5] clk: renesas: r8a77990: " Niklas Söderlund
2020-12-10 12:36 ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 5/5] clk: renesas: r8a77995: " Niklas Söderlund
2020-12-10 12:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUWAnia_cNSgsGWS7DMpj=vPzpb3NJwf-mXQAJnEwTR8Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).