From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97942C432C0 for ; Tue, 3 Dec 2019 18:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71C8520803 for ; Tue, 3 Dec 2019 18:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbfLCSvP (ORCPT ); Tue, 3 Dec 2019 13:51:15 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:38255 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726766AbfLCSvP (ORCPT ); Tue, 3 Dec 2019 13:51:15 -0500 Received: by mail-ot1-f66.google.com with SMTP id z25so3890277oti.5; Tue, 03 Dec 2019 10:51:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4hLOBykbGdw1liJmGR7zdbjWF/AatltGdR05B3u8wIk=; b=gqrckh8oE+u/O1VRq3zxkhVWEFU1z4pM2v8M4ZigFs2dwzSXpdP6H0sRl7vHImUpp7 EYI9jG6fPW65oyxIGYhG09K6rjVoCV7VWFBSt3p1zt4bVkj+JEbPvN7/ajHjtHzrSgY0 P/CbGH3lXcWj1d/QW9dAF2FDLV8bbaXzEB1GsUR3XAzSdUypDOXOZD9210lImKu4BIxE c4uPDF5NqbXl3leAYwtDOfh5CpK+X2nWKJcdU5jG+DkSDbMc7X5P8CdrWnRdDd6k7yRI CKQCOlcJMvuZvSjJGSYpea1nm3TvbhWB6WW7qeKF+elcReWQod0nt3j4JFZ7SREd+vXv hvUQ== X-Gm-Message-State: APjAAAW8h8uFjzqTWaoDa8jCdtHyY2+hf3aAxpovvlzmqGtJ1R3rZQnD p4yxbX6ynxMfF2Wk4IHSEh7YZwugG6mg2FMhzYE= X-Google-Smtp-Source: APXvYqzZ4oo2pJfvg5MVOk89f23ud9VOzcxrq1j4J+lTteiIrj46hoyfYObEFueWeAaT1h0ORL8ozymCjJbIhLZXTKY= X-Received: by 2002:a9d:3a37:: with SMTP id j52mr4387892otc.39.1575399073988; Tue, 03 Dec 2019 10:51:13 -0800 (PST) MIME-Version: 1.0 References: <20191203034519.5640-1-chris.brandt@renesas.com> <20191203034519.5640-2-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 3 Dec 2019 19:51:02 +0100 Message-ID: Subject: Re: [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support To: Chris Brandt Cc: Mark Brown , Rob Herring , Mark Rutland , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , linux-spi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk , Mason Yang , Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Chris, On Tue, Dec 3, 2019 at 7:46 PM Chris Brandt wrote: > On Tue, Dec 3, 2019, Geert Uytterhoeven wrote: > > > + unsigned long flags; > > > > = 0 here... > > > > > > + flags = 0; > > > > ... instead of here? > > That was my first thought too...and it was wrong. > > If of_clk_detect_critical does NOT detect a critical clock, it does not > touch flags at all. > And since it is a loop, what you get is after the first clock is marked > as CRITICAL, all the remaining clocks also get marked CRITICAL. In this > case, both spibsc0 and spibsc1 get marked critical. That's why I have to > reset it for each loop. Thanks, I missed this is done inside a loop. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds