From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023E5C43381 for ; Thu, 21 Feb 2019 15:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEB9920842 for ; Thu, 21 Feb 2019 15:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbfBUPoH (ORCPT ); Thu, 21 Feb 2019 10:44:07 -0500 Received: from mail-ua1-f66.google.com ([209.85.222.66]:35103 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfBUPoH (ORCPT ); Thu, 21 Feb 2019 10:44:07 -0500 Received: by mail-ua1-f66.google.com with SMTP id f88so2021548uaf.2; Thu, 21 Feb 2019 07:44:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Ujnw5Uiwkv5qTiAYI4IO+ayFYK6PgidtMZeh00Ee/Y=; b=pFTjM1h/yqZ3lTbR6XBcfA6TFCo7I+SAmse3h2QFMKlQP1LZ3YdlQJxxmfGndus2hh /AG0NmUPFrle3sECi7hu9C4fD82K0P9pazxO/21weTYfnH8a1wewyFRlMNhJUbZerD8o +YJQN0/uAH1A3CFPclvHs7QvMMzE7cKq5Yt2tJHKkv6aICwWJW2stsM1jyHVIWgIPnj9 8+rkhwst4MOf3U3SqZcuykbeaJCN6RTV1mtkR3XCsQrLbDPlFrhwhiqmidxaDZiibLPr gGJ0IxYK0MwdCkHCQwA9B1Nu8MAQlxYinaSHtc7HwBf8S7T6+poNtZcYME0jMM2DXihq v5Eg== X-Gm-Message-State: AHQUAuYVR0QHWEUlJmuCzCoVYA6PossDKKRHQRNkNo1P4dW6hnJW42U1 7Z5ZEwG6iW+PV+yU8DQbXU/U+LFxxWDjoFpOQMI= X-Google-Smtp-Source: AHgI3IZkIsmyOUVreh1QOkHEAPFxqcxd77snLAmAV+9Sy/chSvR4jotEu/irvqDdLX1f9A4IiENyMkkEowuXViAeJaU= X-Received: by 2002:a67:fc9a:: with SMTP id x26mr3949088vsp.166.1550763846010; Thu, 21 Feb 2019 07:44:06 -0800 (PST) MIME-Version: 1.0 References: <1550749552-8133-1-git-send-email-krzk@kernel.org> <1550749552-8133-2-git-send-email-krzk@kernel.org> In-Reply-To: <1550749552-8133-2-git-send-email-krzk@kernel.org> From: Geert Uytterhoeven Date: Thu, 21 Feb 2019 16:43:53 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk , Linux ARM , Linux Kernel Mailing List , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, Feb 21, 2019 at 12:47 PM Krzysztof Kozlowski wrote: > During initialization of subdevices if platform_device_alloc() failed, > returned NULL pointer will be later dereferenced. Add proper error > paths to exynos5_clk_register_subcmu(). The return value of this > function is still ignored because at this stage of init there is nothing > we can do. > > Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver") > Cc: > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds