From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966C4C2D0BF for ; Tue, 17 Dec 2019 20:44:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64BD82053B for ; Tue, 17 Dec 2019 20:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbfLQUoE (ORCPT ); Tue, 17 Dec 2019 15:44:04 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34481 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728178AbfLQUoE (ORCPT ); Tue, 17 Dec 2019 15:44:04 -0500 Received: by mail-ot1-f67.google.com with SMTP id a15so2227011otf.1; Tue, 17 Dec 2019 12:44:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vIAFaatzQ9dEbyxMJbeRSvuGBi8SLBfPTGFC4qFE2Wo=; b=ZkEJR7F+HZd8XXFi3lC+m0NWMDbGWChyJldwJU6OAOV9+fDqpy1oopUzswinmoCnP+ m2aS7CZVG624feSoVacLncXKGxACSOc1+Z3yRfyrhibLDmkBLeEC97a2jfbTzEvzutyZ +s1/lDcibmY5guqMom0cLytg8OYbO4W/GbtWSq8/osD6PbrQtxQJfJ61UgKzPkxY0OhD lb7jGyFTzujoySdX25BneoqHrrehSlWvUqZ5RCGczvMcPd9sb/yyxSpBQq1MEELUKluK pIvL+JxQcALzOhN6k6wJNrFLKqznr81xXNnxhSpbT2jS4tEablmVWuoslqyLPG6A9MSi v6+A== X-Gm-Message-State: APjAAAUjZgjpD8ocx37lzTAn8a35NX2Rlxg4GuMTTeZgH90XTl6UH9Yu nIDy+7YHEhlUQEr7CMQySf5roYC3PYf1AvSY6Dk= X-Google-Smtp-Source: APXvYqy6UVIEM4WCuowsz46uqoM8XGNVtkaIIXGrLSDRfNWt02ihLENOR4YxW90YkrUASNscNSxYUWPVicpDGD83Gco= X-Received: by 2002:a05:6830:18e2:: with SMTP id d2mr9993806otf.107.1576615443128; Tue, 17 Dec 2019 12:44:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Tue, 17 Dec 2019 21:43:51 +0100 Message-ID: Subject: Re: [PATCH] clk: renesas: rcar-gen3: allow changing the RPC[D2] clocks To: Sergei Shtylyov Cc: Linux-Renesas , Michael Turquette , Stephen Boyd , Geert Uytterhoeven , linux-clk Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Sergei, On Mon, Oct 7, 2019 at 1:49 PM Sergei Shtylyov wrote: > On 10/07/2019 02:45 PM, Geert Uytterhoeven wrote: > >> I was unable to get clk_set_rate() setting a lower RPC-IF clock frequency > >> and that issue boiled down to me not passing CLK_SET_RATE_PARENT flag to > >> clk_register_composite() when registering the RPC[D2] clocks... > >> > >> Fixes: db4a0073cc82 ("clk: renesas: rcar-gen3: Add RPC clocks") > >> Signed-off-by: Sergei Shtylyov > > > > Thanks for your patch! > > > > LGTM, so > > Reviewed-by: Geert Uytterhoeven > > Thanks. :-) > > > Now, before I apply this: does this make RPC-IF work? > > Unfortunately, no. :-/ As per private communication, I understand the problem is elsewhere, and this patch itself is working fine, and thus safe to apply? Thanks for confirming! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds