linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] clk: renesas: Add TMU clocks
@ 2020-12-09 19:53 Niklas Söderlund
  2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

Hi,

This series adds the missing TMU clocks for most Renesas R-Car Gen3 
SoCs. I have tested this series on all boards but D3 and E3 as I do not 
have access to those. But I see no reason they should not not work 
equally well as they the boards I can test on.

Niklas Söderlund (5):
  clk: renesas: r8a7795: Add TMU clocks
  clk: renesas: r8a7796: Add TMU clocks
  clk: renesas: r8a77965: Add TMU clocks
  clk: renesas: r8a77990: Add TMU clocks
  clk: renesas: r8a77995: Add TMU clocks

 drivers/clk/renesas/r8a7795-cpg-mssr.c  | 5 +++++
 drivers/clk/renesas/r8a7796-cpg-mssr.c  | 5 +++++
 drivers/clk/renesas/r8a77965-cpg-mssr.c | 5 +++++
 drivers/clk/renesas/r8a77990-cpg-mssr.c | 5 +++++
 drivers/clk/renesas/r8a77995-cpg-mssr.c | 5 +++++
 5 files changed, 25 insertions(+)

-- 
2.29.2


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/5] clk: renesas: r8a7795: Add TMU clocks
  2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
@ 2020-12-09 19:53 ` Niklas Söderlund
  2020-12-10 12:32   ` Geert Uytterhoeven
  2020-12-09 19:53 ` [PATCH 2/5] clk: renesas: r8a7796: " Niklas Söderlund
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a7795-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c
index 068018ae3c6e2254..a2102106fad2d01a 100644
--- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
@@ -128,6 +128,11 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
 	DEF_MOD("fdp1-2",		 117,	R8A7795_CLK_S2D1), /* ES1.x */
 	DEF_MOD("fdp1-1",		 118,	R8A7795_CLK_S0D1),
 	DEF_MOD("fdp1-0",		 119,	R8A7795_CLK_S0D1),
+	DEF_MOD("tmu4",			 121,	R8A7795_CLK_S0D6),
+	DEF_MOD("tmu3",			 122,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu2",			 123,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu1",			 124,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu0",			 125,	R8A7795_CLK_CP),
 	DEF_MOD("scif5",		 202,	R8A7795_CLK_S3D4),
 	DEF_MOD("scif4",		 203,	R8A7795_CLK_S3D4),
 	DEF_MOD("scif3",		 204,	R8A7795_CLK_S3D4),
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/5] clk: renesas: r8a7796: Add TMU clocks
  2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
  2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
@ 2020-12-09 19:53 ` Niklas Söderlund
  2020-12-10 12:34   ` Geert Uytterhoeven
  2020-12-09 19:53 ` [PATCH 3/5] clk: renesas: r8a77965: " Niklas Söderlund
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 2cd6e3876fbdcd0a..41593c126faf33a7 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -128,6 +128,11 @@ static const struct cpg_core_clk r8a7796_core_clks[] __initconst = {
 
 static struct mssr_mod_clk r8a7796_mod_clks[] __initdata = {
 	DEF_MOD("fdp1-0",		 119,	R8A7796_CLK_S0D1),
+	DEF_MOD("tmu4",			 121,	R8A7796_CLK_S0D6),
+	DEF_MOD("tmu3",			 122,	R8A7796_CLK_S3D2),
+	DEF_MOD("tmu2",			 123,	R8A7796_CLK_S3D2),
+	DEF_MOD("tmu1",			 124,	R8A7796_CLK_S3D2),
+	DEF_MOD("tmu0",			 125,	R8A7796_CLK_CP),
 	DEF_MOD("scif5",		 202,	R8A7796_CLK_S3D4),
 	DEF_MOD("scif4",		 203,	R8A7796_CLK_S3D4),
 	DEF_MOD("scif3",		 204,	R8A7796_CLK_S3D4),
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/5] clk: renesas: r8a77965: Add TMU clocks
  2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
  2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
  2020-12-09 19:53 ` [PATCH 2/5] clk: renesas: r8a7796: " Niklas Söderlund
@ 2020-12-09 19:53 ` Niklas Söderlund
  2020-12-10 12:35   ` Geert Uytterhoeven
  2020-12-09 19:53 ` [PATCH 4/5] clk: renesas: r8a77990: " Niklas Söderlund
  2020-12-09 19:53 ` [PATCH 5/5] clk: renesas: r8a77995: " Niklas Söderlund
  4 siblings, 1 reply; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a77965-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a77965-cpg-mssr.c b/drivers/clk/renesas/r8a77965-cpg-mssr.c
index 2b55a06ac5cf238f..46a157732759c394 100644
--- a/drivers/clk/renesas/r8a77965-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c
@@ -123,6 +123,11 @@ static const struct cpg_core_clk r8a77965_core_clks[] __initconst = {
 
 static const struct mssr_mod_clk r8a77965_mod_clks[] __initconst = {
 	DEF_MOD("fdp1-0",		119,	R8A77965_CLK_S0D1),
+	DEF_MOD("tmu4",			121,	R8A77965_CLK_S0D6),
+	DEF_MOD("tmu3",			122,	R8A77965_CLK_S3D2),
+	DEF_MOD("tmu2",			123,	R8A77965_CLK_S3D2),
+	DEF_MOD("tmu1",			124,	R8A77965_CLK_S3D2),
+	DEF_MOD("tmu0",			125,	R8A77965_CLK_CP),
 	DEF_MOD("scif5",		202,	R8A77965_CLK_S3D4),
 	DEF_MOD("scif4",		203,	R8A77965_CLK_S3D4),
 	DEF_MOD("scif3",		204,	R8A77965_CLK_S3D4),
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/5] clk: renesas: r8a77990: Add TMU clocks
  2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
                   ` (2 preceding siblings ...)
  2020-12-09 19:53 ` [PATCH 3/5] clk: renesas: r8a77965: " Niklas Söderlund
@ 2020-12-09 19:53 ` Niklas Söderlund
  2020-12-10 12:36   ` Geert Uytterhoeven
  2020-12-09 19:53 ` [PATCH 5/5] clk: renesas: r8a77995: " Niklas Söderlund
  4 siblings, 1 reply; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a77990-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a77990-cpg-mssr.c b/drivers/clk/renesas/r8a77990-cpg-mssr.c
index 2b97ab61d044ca07..2d172f80b34c277d 100644
--- a/drivers/clk/renesas/r8a77990-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a77990-cpg-mssr.c
@@ -124,6 +124,11 @@ static const struct cpg_core_clk r8a77990_core_clks[] __initconst = {
 };
 
 static const struct mssr_mod_clk r8a77990_mod_clks[] __initconst = {
+	DEF_MOD("tmu4",			 121,	R8A77990_CLK_S0D6C),
+	DEF_MOD("tmu3",			 122,	R8A77990_CLK_S3D2C),
+	DEF_MOD("tmu2",			 123,	R8A77990_CLK_S3D2C),
+	DEF_MOD("tmu1",			 124,	R8A77990_CLK_S3D2C),
+	DEF_MOD("tmu0",			 125,	R8A77990_CLK_CP),
 	DEF_MOD("scif5",		 202,	R8A77990_CLK_S3D4C),
 	DEF_MOD("scif4",		 203,	R8A77990_CLK_S3D4C),
 	DEF_MOD("scif3",		 204,	R8A77990_CLK_S3D4C),
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 5/5] clk: renesas: r8a77995: Add TMU clocks
  2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
                   ` (3 preceding siblings ...)
  2020-12-09 19:53 ` [PATCH 4/5] clk: renesas: r8a77990: " Niklas Söderlund
@ 2020-12-09 19:53 ` Niklas Söderlund
  2020-12-10 12:41   ` Geert Uytterhoeven
  4 siblings, 1 reply; 11+ messages in thread
From: Niklas Söderlund @ 2020-12-09 19:53 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a77995-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a77995-cpg-mssr.c b/drivers/clk/renesas/r8a77995-cpg-mssr.c
index 5b4691117b470556..9cfd00cf4e69aa45 100644
--- a/drivers/clk/renesas/r8a77995-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a77995-cpg-mssr.c
@@ -111,6 +111,11 @@ static const struct cpg_core_clk r8a77995_core_clks[] __initconst = {
 };
 
 static const struct mssr_mod_clk r8a77995_mod_clks[] __initconst = {
+	DEF_MOD("tmu4",			 121,	R8A77995_CLK_S1D4C),
+	DEF_MOD("tmu3",			 122,	R8A77995_CLK_S3D2C),
+	DEF_MOD("tmu2",			 123,	R8A77995_CLK_S3D2C),
+	DEF_MOD("tmu1",			 124,	R8A77995_CLK_S3D2C),
+	DEF_MOD("tmu0",			 125,	R8A77995_CLK_CP),
 	DEF_MOD("scif5",		 202,	R8A77995_CLK_S3D4C),
 	DEF_MOD("scif4",		 203,	R8A77995_CLK_S3D4C),
 	DEF_MOD("scif3",		 204,	R8A77995_CLK_S3D4C),
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/5] clk: renesas: r8a7795: Add TMU clocks
  2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
@ 2020-12-10 12:32   ` Geert Uytterhoeven
  0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-12-10 12:32 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

Hi Niklas,

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -128,6 +128,11 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
>         DEF_MOD("fdp1-2",                117,   R8A7795_CLK_S2D1), /* ES1.x */
>         DEF_MOD("fdp1-1",                118,   R8A7795_CLK_S0D1),
>         DEF_MOD("fdp1-0",                119,   R8A7795_CLK_S0D1),
> +       DEF_MOD("tmu4",                  121,   R8A7795_CLK_S0D6),

The above is correct for R-Car H3 ES2.0 and later.
On R-Car H3 ES1.x, the parent clock of TMU4 is S3D2 (datasheet rev 0.52),
so you need to add an entry to r8a7795es1_mod_reparent[].

> +       DEF_MOD("tmu3",                  122,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu2",                  123,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu1",                  124,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu0",                  125,   R8A7795_CLK_CP),
>         DEF_MOD("scif5",                 202,   R8A7795_CLK_S3D4),
>         DEF_MOD("scif4",                 203,   R8A7795_CLK_S3D4),
>         DEF_MOD("scif3",                 204,   R8A7795_CLK_S3D4),

The rest looks good to me.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/5] clk: renesas: r8a7796: Add TMU clocks
  2020-12-09 19:53 ` [PATCH 2/5] clk: renesas: r8a7796: " Niklas Söderlund
@ 2020-12-10 12:34   ` Geert Uytterhoeven
  0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-12-10 12:34 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk-for-v5.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/5] clk: renesas: r8a77965: Add TMU clocks
  2020-12-09 19:53 ` [PATCH 3/5] clk: renesas: r8a77965: " Niklas Söderlund
@ 2020-12-10 12:35   ` Geert Uytterhoeven
  0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-12-10 12:35 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk-for-v5.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 4/5] clk: renesas: r8a77990: Add TMU clocks
  2020-12-09 19:53 ` [PATCH 4/5] clk: renesas: r8a77990: " Niklas Söderlund
@ 2020-12-10 12:36   ` Geert Uytterhoeven
  0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-12-10 12:36 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk-for-v5.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 5/5] clk: renesas: r8a77995: Add TMU clocks
  2020-12-09 19:53 ` [PATCH 5/5] clk: renesas: r8a77995: " Niklas Söderlund
@ 2020-12-10 12:41   ` Geert Uytterhoeven
  0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2020-12-10 12:41 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk-for-v5.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-12-10 12:42 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 19:53 [PATCH 0/5] clk: renesas: Add TMU clocks Niklas Söderlund
2020-12-09 19:53 ` [PATCH 1/5] clk: renesas: r8a7795: " Niklas Söderlund
2020-12-10 12:32   ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 2/5] clk: renesas: r8a7796: " Niklas Söderlund
2020-12-10 12:34   ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 3/5] clk: renesas: r8a77965: " Niklas Söderlund
2020-12-10 12:35   ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 4/5] clk: renesas: r8a77990: " Niklas Söderlund
2020-12-10 12:36   ` Geert Uytterhoeven
2020-12-09 19:53 ` [PATCH 5/5] clk: renesas: r8a77995: " Niklas Söderlund
2020-12-10 12:41   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).