From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A039C4707A for ; Fri, 21 May 2021 15:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A7FD613CB for ; Fri, 21 May 2021 15:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237338AbhEUPRh (ORCPT ); Fri, 21 May 2021 11:17:37 -0400 Received: from mail-vs1-f49.google.com ([209.85.217.49]:37532 "EHLO mail-vs1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhEUPRg (ORCPT ); Fri, 21 May 2021 11:17:36 -0400 Received: by mail-vs1-f49.google.com with SMTP id s15so10543895vsi.4; Fri, 21 May 2021 08:16:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZjH8fPaY2o8f5Ib7RZj1gMaw/NXIuKmhbkZfvqyPn5I=; b=dRW1OjE8TagNGSJDR2DxP6jYLjWeKzOyuq3D6bbbGn+k4KN5Y7z9klnx7t5PIxxpry DvcSE8/K+dDQvux8XxitZWGtBp6cMMBXf3gdBSwElSvuQnc/kc9Yp1dcpshJ6dy0xUZX uryDBXiDjlOjZbEbo7x9F/tiBvlxIPhfdIeu756Ue11tDXv/Pxj0mXSk8oZMWyxhUFrl Mc1J+0OEWACgFd+6bXBLOkhrGPevvS1PL2GgLI/zGCpSdbEC8NisCjQz4AQ4qV2ikuZT x2qoG46QNM6EWS/22oxKXDQD59IMj4ox//W8Wa5iz8QRmpxrM2KpoulyQ77rY9xihwrV qzVA== X-Gm-Message-State: AOAM532mfk0T2fCR10PN+iadsQoehj4TdunBU6AhGlKdby2vKPBMpZUH BBwvfFteuJucDx2+BfR7AoSQjDK34JDj//5KvBM= X-Google-Smtp-Source: ABdhPJx8Ajdh/v2OoW95fXlR3EdAJCqsWTRUG9iGhYqfk38ZBsPFymjTEjfn+Kf+9AyJ7sOkWVT6IygojHInYWXe4/Q= X-Received: by 2002:a67:fb52:: with SMTP id e18mr11430842vsr.18.1621610171231; Fri, 21 May 2021 08:16:11 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-10-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 21 May 2021 17:15:59 +0200 Message-ID: Subject: Re: [PATCH 09/16] dt-bindings: serial: renesas,scif: Document r9a07g044 bindings To: Lad Prabhakar Cc: Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das , Prabhakar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Prabhakar, On Fri, May 21, 2021 at 3:26 PM Geert Uytterhoeven wrote: > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > wrote: > > Document R9A07G044 SoC variants, common compatiable string > > "renesas,scif-r9a07g044" is added for RZ/G2L and RZ/G2LC SoC. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Biju Das > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -64,6 +64,10 @@ properties: > > - const: renesas,rcar-gen3-scif # R-Car Gen3 and RZ/G2 > > - const: renesas,scif # generic SCIF compatible UART > > > > + - items: > > + - enum: > > + - renesas,scif-r9a07g044 # RZ/G2{L,LC} > > + > > reg: > > maxItems: 1 > > Looks good to me. > > Do interrupts and interrupt-names need to be updated? > The SCIF node added in "[PATCH 15/16] arm64: dts: renesas: Add initial > DTSI for RZ/G2{L,LC} SoC's" has 5 interrupts, while the bindings > support only 1, 4, or 6 interrupts. According to the SoC interrupt mapping, "tei" and "dri" share an interrupt, so 6 interrupts is correct, and this part of the binding does not need an update. Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds