* [PATCH] of: clk: Make <linux/of_clk.h> self-contained
@ 2020-02-05 19:46 Geert Uytterhoeven
2020-02-05 22:51 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-02-05 19:46 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, Michael Turquette, Stephen Boyd
Cc: devicetree, linux-clk, linux-kernel, Geert Uytterhoeven
Depending on include order:
include/linux/of_clk.h:11:45: warning: ‘struct device_node’ declared inside parameter list will not be visible outside of this definition or declaration
unsigned int of_clk_get_parent_count(struct device_node *np);
^~~~~~~~~~~
include/linux/of_clk.h:12:43: warning: ‘struct device_node’ declared inside parameter list will not be visible outside of this definition or declaration
const char *of_clk_get_parent_name(struct device_node *np, int index);
^~~~~~~~~~~
include/linux/of_clk.h:13:31: warning: ‘struct of_device_id’ declared inside parameter list will not be visible outside of this definition or declaration
void of_clk_init(const struct of_device_id *matches);
^~~~~~~~~~~~
Fix this by adding forward declarations for struct device_node and
struct of_device_id.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Noticed when cleaning up some platform code.
I am not aware of this being triggered in upstream, but this will become a
dependency for these cleanups.
include/linux/of_clk.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/of_clk.h b/include/linux/of_clk.h
index b27da9f164cbd221..c86fcad23fc21725 100644
--- a/include/linux/of_clk.h
+++ b/include/linux/of_clk.h
@@ -6,6 +6,9 @@
#ifndef __LINUX_OF_CLK_H
#define __LINUX_OF_CLK_H
+struct device_node;
+struct of_device_id;
+
#if defined(CONFIG_COMMON_CLK) && defined(CONFIG_OF)
unsigned int of_clk_get_parent_count(struct device_node *np);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained
2020-02-05 19:46 [PATCH] of: clk: Make <linux/of_clk.h> self-contained Geert Uytterhoeven
@ 2020-02-05 22:51 ` Stephen Boyd
2020-02-06 8:06 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-02-05 22:51 UTC (permalink / raw)
To: Frank Rowand, Geert Uytterhoeven, Michael Turquette, Rob Herring
Cc: devicetree, linux-clk, linux-kernel, Geert Uytterhoeven
Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> Depending on include order:
>
> include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> unsigned int of_clk_get_parent_count(struct device_node *np);
> ^~~~~~~~~~~
> include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> const char *of_clk_get_parent_name(struct device_node *np, int index);
> ^~~~~~~~~~~
> include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> void of_clk_init(const struct of_device_id *matches);
> ^~~~~~~~~~~~
>
> Fix this by adding forward declarations for struct device_node and
> struct of_device_id.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Noticed when cleaning up some platform code.
> I am not aware of this being triggered in upstream, but this will become a
> dependency for these cleanups.
So apply for fixes? I'll just throw it in now.
Applied to clk-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained
2020-02-05 22:51 ` Stephen Boyd
@ 2020-02-06 8:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-02-06 8:06 UTC (permalink / raw)
To: Stephen Boyd
Cc: Frank Rowand, Geert Uytterhoeven, Michael Turquette, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-clk, Linux Kernel Mailing List
Hi Stephen,
On Wed, Feb 5, 2020 at 11:51 PM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> > Depending on include order:
> >
> > include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > unsigned int of_clk_get_parent_count(struct device_node *np);
> > ^~~~~~~~~~~
> > include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > const char *of_clk_get_parent_name(struct device_node *np, int index);
> > ^~~~~~~~~~~
> > include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > void of_clk_init(const struct of_device_id *matches);
> > ^~~~~~~~~~~~
> >
> > Fix this by adding forward declarations for struct device_node and
> > struct of_device_id.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Noticed when cleaning up some platform code.
> > I am not aware of this being triggered in upstream, but this will become a
> > dependency for these cleanups.
>
> So apply for fixes? I'll just throw it in now.
Yep.
> Applied to clk-next.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-06 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 19:46 [PATCH] of: clk: Make <linux/of_clk.h> self-contained Geert Uytterhoeven
2020-02-05 22:51 ` Stephen Boyd
2020-02-06 8:06 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).