From: Baolin Wang <baolin.wang@linaro.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()
Date: Tue, 5 Nov 2019 16:24:58 +0800 [thread overview]
Message-ID: <CAMz4kuJcqs5pSyEqZ1v0Eb9-zaRrqoGvPMCEjfpgAmWkDcvrxA@mail.gmail.com> (raw)
In-Reply-To: <1995139bee5248ff3e9d46dc715968f212cfc4cc.1570520268.git.baolin.wang@linaro.org>
Hi Stephen,
On Tue, 8 Oct 2019 at 15:41, Baolin Wang <baolin.wang@linaro.org> wrote:
>
> The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
> IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
>
> Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure")
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> Changes from v1:
> - Add fixes tag.
> ---
I did not see this patch in your clk tree (you only applied patch 2 in
this patch set), could you apply this patch if no other issues?
Thanks.
> drivers/clk/sprd/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> index 9d56eac..7ad5ba2 100644
> --- a/drivers/clk/sprd/common.c
> +++ b/drivers/clk/sprd/common.c
> @@ -46,7 +46,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
>
> if (of_find_property(node, "sprd,syscon", NULL)) {
> regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
> - if (IS_ERR_OR_NULL(regmap)) {
> + if (IS_ERR(regmap)) {
> pr_err("%s: failed to get syscon regmap\n", __func__);
> return PTR_ERR(regmap);
> }
> --
> 1.7.9.5
>
--
Baolin Wang
Best Regards
next prev parent reply other threads:[~2019-11-05 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 7:41 [PATCH v2 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Baolin Wang
2019-10-08 7:41 ` [PATCH v2 2/2] clk: sprd: Change to use devm_platform_ioremap_resource() Baolin Wang
2019-10-16 23:18 ` Stephen Boyd
2019-11-05 8:24 ` Baolin Wang [this message]
2019-11-13 23:00 ` [PATCH v2 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuJcqs5pSyEqZ1v0Eb9-zaRrqoGvPMCEjfpgAmWkDcvrxA@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).