From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CE4ECE58F for ; Wed, 16 Oct 2019 01:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 051362067D for ; Wed, 16 Oct 2019 01:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="izgh3XKF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731634AbfJPBfo (ORCPT ); Tue, 15 Oct 2019 21:35:44 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:44411 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731559AbfJPBfo (ORCPT ); Tue, 15 Oct 2019 21:35:44 -0400 Received: by mail-lf1-f68.google.com with SMTP id q12so15968327lfc.11 for ; Tue, 15 Oct 2019 18:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TAK0ELSb5Txq6hlGzxUJ6nHkFu1g4zycq1EzpQGbhM4=; b=izgh3XKFqg2kZAGdfYdAfOhQQ6KpkjI8iTZ8c1Lr8PlQRMAZphydKFz78i+zSDlCSZ UT5jsT8AgO7FABZndi3SeybQJpocK1a8s1lx0ntSmyfA5Soy3hfSq5O/AYWB8RfrBOoz PAAu8kGYfbYEiDG+UJHdI8QtREm44JM2ifxHjZJZ5wxxDy4vPcnzczyggQaueoQWLuhV AB4yexBVZ/OavmFHVuFZ74e0CPoXPldOBKZZs2sCk6Ukpzf1+F4XOXgXbx4TkPv0TF0m FMGpa7XbKjTxEzdFnF0iIGulhptYSLodMrsV4MTy9cAcDDSWtSXkh9C1dybVb2KqIuQB Pa2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TAK0ELSb5Txq6hlGzxUJ6nHkFu1g4zycq1EzpQGbhM4=; b=XEHi08YiGaObSk9uzfEtEhSox07GUtlFbGLe+7DdZXXFx4kXnvMlFKbW45jqWRD+Nf wSnuMItNEanxo+Wj4mzyVwsWr+S/kuic+jI2UsMLvXBidmSh35/exLmM+M3h9fdr0m7n lIrgQEvENsvX6ihMBTYiwbd7rtSvZT4AqDvey6lMUUZotsQeORZSm1PrkbKoSM9bhbZ+ nW5hSyUrwLN7lc0LXjPtkjzBgtLFinb+kMuj3yNA/2E56xkGiZj/xb23r8/zpfxEYftk mBecidj1pBqikFOuamC5ev7XlIWQm+YpWzLOsSO8EhDOl1LKB3c+SYrZsxs4BqIsiPA7 K/kQ== X-Gm-Message-State: APjAAAVXVDzpZI2tn+NWBEd0fms80QmbZa77Rl+4uZ5/zCL6liV2aMfB TKaPD80aNQAC4+0ACYr13nD5nCUV9jVVTu5jGy+W8w== X-Google-Smtp-Source: APXvYqyk7m5EdKuiBS0AO5QBu6Ah2Gie2qHdmwJJXHoDUDdkh8c5PFOLmOA8qr27FCuTD1k9eW+WcoN7UwYZBPgSNSA= X-Received: by 2002:a19:ad4c:: with SMTP id s12mr24153597lfd.49.1571189742556; Tue, 15 Oct 2019 18:35:42 -0700 (PDT) MIME-Version: 1.0 References: <20191015142144.23544-1-yuehaibing@huawei.com> In-Reply-To: <20191015142144.23544-1-yuehaibing@huawei.com> From: Baolin Wang Date: Wed, 16 Oct 2019 09:35:30 +0800 Message-ID: Subject: Re: [PATCH -next] clk: sprd: use devm_platform_ioremap_resource() to simplify code To: YueHaibing Cc: Michael Turquette , Stephen Boyd , Orson Zhai , Chunyan Zhang , linux-clk@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, On Tue, 15 Oct 2019 at 22:22, YueHaibing wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing We already posted a patch to do this, thanks anyway. https://lore.kernel.org/patchwork/patch/1136894/ > --- > drivers/clk/sprd/common.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c > index 9d56eac..3718696 100644 > --- a/drivers/clk/sprd/common.c > +++ b/drivers/clk/sprd/common.c > @@ -42,7 +42,6 @@ int sprd_clk_regmap_init(struct platform_device *pdev, > void __iomem *base; > struct device_node *node = pdev->dev.of_node; > struct regmap *regmap; > - struct resource *res; > > if (of_find_property(node, "sprd,syscon", NULL)) { > regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon"); > @@ -51,8 +50,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, > return PTR_ERR(regmap); > } > } else { > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(&pdev->dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > > -- > 2.7.4 > > -- Baolin Wang Best Regards