From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED406C49ED9 for ; Thu, 12 Sep 2019 09:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C410D20856 for ; Thu, 12 Sep 2019 09:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hWMSgmlL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730680AbfILJrc (ORCPT ); Thu, 12 Sep 2019 05:47:32 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:37485 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730691AbfILJrb (ORCPT ); Thu, 12 Sep 2019 05:47:31 -0400 Received: by mail-qk1-f194.google.com with SMTP id u184so20932577qkd.4 for ; Thu, 12 Sep 2019 02:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=njDtF8upkA6+NaauiLZUsAxJubAF9fG83zymry8vAaU=; b=hWMSgmlLtCEWRX/MHXkshsdVSzIZAXdwroHnFWd1J+Pi/zDbGAZcyCfZPRTWouMTs3 HjdnM7SbArudL+LwJw9WXwtNhkxNJ3vPlJTBXwcwK+HnfsDPaTouep35wtRSaBTUpjrI 9emk8DOaWZePVDjguyhCt/ZL5d6Jbv6RqoCnfcdaExjJj3B1O2Clo5CXX+ScgLcmxCOf 9/ugnWmvMifS7Z+DvKaoS9sgQ0er8SxLA0lyfPk5VTk9hpa5RR1ZuoDNDMMCWrBadl7y 3s3xpnuk7FYIRnmUpF5Mf7/DQ3YY1oZ0lqDWccoUZ59bcKSlG6yXZueBxl49+QYWgfcz G4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=njDtF8upkA6+NaauiLZUsAxJubAF9fG83zymry8vAaU=; b=O8SGADWhAnGCG8jwzO2rsY6K+9srJNAgs/MDgslbNRmT1hAiZ7+mz/ajM1GRDqs2W1 lc0AQjV3DJthCObsLU2dDq7YKqvIbwTcGgreImMJW9jgOyTdHkMpcx0NtQKZRRrcT78O t3ApaWzyuFIyBRGXhiLHwb1fUgxYRJj0Ws7JnpoQBwCg4oJNkcrcxw/XXS98rmp7I5D9 LtBMEkDLoVWpFb6SHT+rh05KpWLnL94mdDuRuKAwRJkkA1zzMTAxZeKRpVdb2mlRao9f 57SqWDQVKz7LLUE6bSoC2DQVYQvARgH5Y2nLnJjykRzfBfPi+DxTxf73M6bQiOZSlm9U 63Uw== X-Gm-Message-State: APjAAAVEps4q5Sknz4NvkqjFNmG9tROwKUQ0eO2t66XQWC5kSDMDVtI2 635JFG3X+MaFpUOfO9ABQ2KJ10akqGZKKXHAg3xIYw== X-Google-Smtp-Source: APXvYqz/1oDNL1ZZfCatdlik6ssSKqxLf+19ecAGHXvhEDBbY9mBKtVG6u/Wq02n39I2GGkc6GmOYewOwwhK8D9OZR8= X-Received: by 2002:a37:6d2:: with SMTP id 201mr39608673qkg.106.1568281649476; Thu, 12 Sep 2019 02:47:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kucheria Date: Thu, 12 Sep 2019 15:17:18 +0530 Message-ID: Subject: Re: [PATCH 0/4] Cleanup arm64 driver dependencies To: Arnd Bergmann Cc: "linux-kernel@vger.kernel.org" , Linux ARM , arm-soc , Bartosz Golaszewski , Catalin Marinas , Kishon Vijay Abraham I , Liam Girdwood , Linus Walleij , Lorenzo Pieralisi , Mark Brown , Michael Turquette , Sebastian Reichel , Stephen Boyd , Will Deacon , linux-clk , "open list:GPIO SUBSYSTEM" , linux-pci , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Archived-At: List-Archive: List-Post: Hi Arnd, On Thu, Sep 12, 2019 at 2:59 PM Arnd Bergmann wrote: > > On Thu, Sep 12, 2019 at 12:18 AM Amit Kucheria wrote: > > > > I was using initcall_debugging on a QCOM platform and ran across a bunch of > > driver initcalls that are enabled even if their SoC support is disabled. > > > > Here are some fixups for a subset of them. > > The idea seems reasonable, disabling a platform may just turn off > all the drivers that are not useful elsewhere, but there are mistakes > in a lot of your changes, so I'm certainly not applying these for 5.4. OK, thanks for confirming that you have no objections to such changes, per-se. I'll spend some more time ensuring COMPILE_TEST coverage for these cleanups. I only focused on quickly cleaning up my initcall_debug output for now. > Generally speaking, the way that works best is > > config SUBSYS_DRIVER_FOO > tristate "SUBSYS support for FOO platform" > depends on ARCH_FOO || COMPILE_TEST > depends on SUBSYS > default "m" if ARCH_FOO > > This means it's enabled as a loadable module by default (use > default "y" instead where necessary) as long as the platform > is enabled, but an x86 allmodconfig build also includes it > because of COMPILE_TEST, while any configuration without > ARCH_FOO that is not compile-testing cannot enable it. How would you like to handle defconfigs which list a driver explicitly? Should we add ARCH_FOO to those defconfigs or remove DRIVER_FOO from them? Regards, Amit