From: Anson Huang <anson.huang@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Aisheng Dong <aisheng.dong@nxp.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-clk <linux-clk@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] clk: imx7ulp: Correct system clock source option #7
Date: Sat, 12 Oct 2019 01:05:24 +0000 [thread overview]
Message-ID: <DB3PR0402MB391628A077B9D689469D38E3F5960@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5DUVv_cT59pTBmfa60TM0E9=6rFdpDw71g_6cQidOPW+A@mail.gmail.com>
Hi, Fabio
> On Fri, Oct 11, 2019 at 5:39 AM Anson Huang <Anson.Huang@nxp.com>
> wrote:
> >
> > In the latest reference manual Rev.0,06/2019, the SCG1's system
>
> This should be SCS instead of SCG1.
The reference states SCG system clock, SCS stands for system clock source, so I think
it is actually meaning SCG1's system clock source😊
Selects the SCG system clock.
0000b - Reserved
0001b - System OSC (SOSC_CLK)
0010b - Slow IRC (SIRC_CLK)
0011b - Fast IRC (FIRC_CLK)
0100b - Reserved
0101b - Auxiliary PLL (APLL_CLK)
0110b - System PLL (SPLL_CLK)
0111b - Reserved
>
> > clock source option #7 is no longer from upll, it is reserved, update
> > clock driver accordingly.
> >
> > Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks,
Anson
next prev parent reply other threads:[~2019-10-12 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 8:36 [PATCH] clk: imx7ulp: Correct system clock source option #7 Anson Huang
2019-10-11 11:14 ` Fabio Estevam
2019-10-12 1:05 ` Anson Huang [this message]
2019-10-12 12:43 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB391628A077B9D689469D38E3F5960@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).