linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wen He <wen.he_1@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Walle <michael@walle.cc>, Leo Li <leoyang.li@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [v11 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings
Date: Fri, 6 Dec 2019 03:01:44 +0000	[thread overview]
Message-ID: <DB7PR04MB519531AFC4C84AE8A5916E95E25F0@DB7PR04MB5195.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191205142649.GA22738@bogus>



> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2019年12月5日 22:27
> To: Wen He <wen.he_1@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael Walle
> <michael@walle.cc>; Leo Li <leoyang.li@nxp.com>;
> devicetree@vger.kernel.org; linux-clk@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [v11 1/2] dt/bindings: clk: Add YAML schemas for LS1028A
> Display Clock bindings
> 
> Caution: EXT Email
> 
> On Thu, Dec 05, 2019 at 03:26:52PM +0800, Wen He wrote:
> > LS1028A has a clock domain PXLCLK0 used for provide pixel clocks to
> > Display output interface. Add a YAML schema for this.
> >
> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> > change in v11:
> >       - renamed 'vco-frequency' to 'fsl,vco-hz' to clearly feild
> > definiation
> >
> >  .../devicetree/bindings/clock/fsl,plldig.yaml | 55
> > +++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/clock/fsl,plldig.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
> > b/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
> > new file mode 100644
> > index 000000000000..23cce65b3a93
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fbindings%2Fclock%2Ffsl%2Cplldig.yaml%23&amp;
> da
> >
> +ta=02%7C01%7Cwen.he_1%40nxp.com%7Cbc3e7eabcfef4f75316e08d7798f
> 2c2e%7C
> >
> +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63711152813315072
> 4&amp;sda
> >
> +ta=vFRvWaWgdyIWqQAVE7NXnUKCnE%2BU38svA%2BjWqNc%2Fb8w%3D&a
> mp;reserved=
> > +0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=02%7C01%7Cwen
> .he_1%
> >
> +40nxp.com%7Cbc3e7eabcfef4f75316e08d7798f2c2e%7C686ea1d3bc2b4c6f
> a92cd9
> >
> +9c5c301635%7C0%7C0%7C637111528133150724&amp;sdata=dqj%2FBK%2
> F4%2BBmfk
> > +HkGjeNZm3FZZlTYPJOzEKroyH0jKDA%3D&amp;reserved=0
> > +
> > +title: NXP QorIQ Layerscape LS1028A Display PIXEL Clock Binding
> > +
> > +maintainers:
> > +  - Wen He <wen.he_1@nxp.com>
> > +
> > +description: |
> > +  NXP LS1028A has a clock domain PXLCLK0 used for the Display output
> > +  interface in the display core, as implemented in TSMC CLN28HPM PLL.
> > +  which generate and offers pixel clocks to Display.
> > +
> > +properties:
> > +  compatible:
> > +    const: fsl,ls1028a-plldig
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 0
> > +
> > +  fsl,vco-hz:
> > +     $ref: '/schemas/types.yaml#/definitions/uint32'
> 
> Drop this as '*-hz' already has a type.
> 
> With that,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks a lot; 

Best Regards,
Wen

> 
> > +     description: Optional for VCO frequency of the PLL in Hertz.
> > +        The VCO frequency of this PLL cannot be changed during runtime
> > +        only at startup. Therefore, the output frequencies are very
> > +        limited and might not even closely match the requested
> frequency.
> > +        To work around this restriction the user may specify its own
> > +        desired VCO frequency for the PLL.
> > +     minimum: 650000000
> > +     maximum: 1300000000
> > +     default: 1188000000
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - '#clock-cells'
> > +
> > +examples:
> > +  # Display PIXEL Clock node:
> > +  - |
> > +    dpclk: clock-display@f1f0000 {
> > +        compatible = "fsl,ls1028a-plldig";
> > +        reg = <0x0 0xf1f0000 0x0 0xffff>;
> > +        #clock-cells = <0>;
> > +        clocks = <&osc_27m>;
> > +    };
> > +
> > +...
> > --
> > 2.17.1
> >

      reply	other threads:[~2019-12-06  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  7:26 Wen He
2019-12-05  7:26 ` [v11 2/2] clk: ls1028a: Add clock driver for Display output interface Wen He
2019-12-09  9:13   ` Wen He
2019-12-12 22:18   ` Stephen Boyd
2019-12-13  0:06     ` Michael Walle
2019-12-16 17:55       ` Stephen Boyd
2019-12-17  7:08         ` [EXT] " Wen He
2019-12-20 14:42           ` Michael Walle
2019-12-05 14:26 ` [v11 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings Rob Herring
2019-12-06  3:01   ` Wen He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB519531AFC4C84AE8A5916E95E25F0@DB7PR04MB5195.eurprd04.prod.outlook.com \
    --to=wen.he_1@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michael@walle.cc \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --subject='RE: [EXT] Re: [v11 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).