Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: Wen He <wen.he_1@nxp.com>
To: Leo Li <leoyang.li@nxp.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-devel@linux.nxdi.nxp.com" <linux-devel@linux.nxdi.nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] RE: [v6 2/2] clk: ls1028a: Add clock driver for Display output interface
Date: Mon, 11 Nov 2019 02:02:12 +0000
Message-ID: <DB7PR04MB5195F74447DC13B2AD9238E7E2740@DB7PR04MB5195.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CADRPPNQ8zf_+205OK=g1FvKpjghFwuyBVW3Wy4zC8VMN2bLdhQ@mail.gmail.com>



> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: 2019年11月9日 4:20
> To: Wen He <wen.he_1@nxp.com>
> Cc: Stephen Boyd <sboyd@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Michael Turquette <mturquette@baylibre.com>;
> Rob Herring <robh+dt@kernel.org>; devicetree@vger.kernel.org;
> linux-clk@vger.kernel.org; linux-devel@linux.nxdi.nxp.com;
> linux-kernel@vger.kernel.org
> Subject: Re: [EXT] RE: [v6 2/2] clk: ls1028a: Add clock driver for Display output
> interface
> 
> Caution: EXT Email
> 
> On Thu, Nov 7, 2019 at 8:21 PM Wen He <wen.he_1@nxp.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Stephen Boyd <sboyd@kernel.org>
> > > Sent: 2019年11月8日 6:58
> > > To: Leo Li <leoyang.li@nxp.com>; Mark Rutland
> > > <mark.rutland@arm.com>; Michael Turquette
> <mturquette@baylibre.com>;
> > > Rob Herring <robh+dt@kernel.org>; Wen He <wen.he_1@nxp.com>;
> > > devicetree@vger.kernel.org; linux-clk@vger.kernel.org;
> > > linux-devel@linux.nxdi.nxp.com; linux-kernel@vger.kernel.org
> > > Subject: [EXT] RE: [v6 2/2] clk: ls1028a: Add clock driver for
> > > Display output interface
> > >
> > > Caution: EXT Email
> > >
> > > Quoting Wen He (2019-11-06 19:13:48)
> > > >
> > > > > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> > > > > > 0138fb14e6f8..d23b7464aba8 100644
> > > > > > --- a/drivers/clk/Makefile
> > > > > > +++ b/drivers/clk/Makefile
> > > > > > @@ -45,6 +45,7 @@ obj-$(CONFIG_COMMON_CLK_OXNAS)
> > > +=
> > > > > > clk-oxnas.o
> > > > > >  obj-$(CONFIG_COMMON_CLK_PALMAS)            +=
> clk-palmas.o
> > > > > >  obj-$(CONFIG_COMMON_CLK_PWM)               +=
> clk-pwm.o
> > > > > >  obj-$(CONFIG_CLK_QORIQ)                    += clk-qoriq.o
> > > > > > +obj-$(CONFIG_CLK_LS1028A_PLLDIG)   += clk-plldig.o
> > > > >
> > > > > Wrong ordering.  This section of Makefile requires ordering by
> > > > > driver file
> > > > > name:
> > > > >
> > > > > # hardware specific clock types
> > > > > # please keep this section sorted lexicographically by file path
> > > > > name
> > > > >
> > > >
> > > > Hi Leo,
> > > >
> > > > Stephen once suggest the Kconfig variable name should be given a
> > > > more specific name like CLK_LS1028A_PLLDIG, so I have to changed it.
> > > >
> > > > Hi Stephen,
> > > >
> > > > How do you think?
> > > >
> > >
> > >
> > > Config name looks fine to me, but you haven't sorted this based on
> > > the file name, i.e. clk-plldig.o, so please insert this in the right place in this
> file.
> >
> > Wow, Understand now..
> >
> > Should be sort this file like below, right?
> > obj-$(CONFIG_COMMON_CLK_PWM)   += clk-pwm.o
> > obj-$(CONFIG_CLK_LS1028A_PLLDIG)   += clk-plldig.o
> > obj-$(CONFIG_CLK_QORIQ)           += clk-qoriq.o
> 
> No.  The correct order should be:
> clk-plldig.o
> clk-pwm.o
> clk-qoriq.o

Understand, I will send next version patch.

Thanks && Best Regards,
Wen

> 
> Regards,
> Leo

      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  9:02 [v6 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings Wen He
2019-11-05  9:02 ` [v6 2/2] clk: ls1028a: Add clock driver for Display output interface Wen He
2019-11-05 21:10   ` Leo Li
2019-11-07  3:13     ` Wen He
2019-11-07 22:57       ` Stephen Boyd
2019-11-08  2:19         ` [EXT] " Wen He
2019-11-08 20:20           ` Li Yang
2019-11-11  2:02             ` Wen He [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB5195F74447DC13B2AD9238E7E2740@DB7PR04MB5195.eurprd04.prod.outlook.com \
    --to=wen.he_1@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-devel@linux.nxdi.nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git