From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: clock: renesas,rcar-usb2-clock-sel: add r8a77961 support
Date: Thu, 26 Mar 2020 02:21:21 +0000 [thread overview]
Message-ID: <TYAPR01MB454437073AE445BF608ECB2ED8CF0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXopMkeBwAQRpphCUXOLeCVRaDEFi-fQzy8_8jzD=MNEw@mail.gmail.com>
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 10:13 PM
<snip>
> > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > @@ -28,6 +28,8 @@ Required properties:
> > an R8A7795 SoC.
> > "renesas,r8a7796-rcar-usb2-clock-sel" if the device if a part of
> > an R8A7796 SoC.
>
> While at it, you may want to update "R8A7796 SoC" to "R8A77960 SoC", to
> avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).
I got it. I'll fix it.
> > + "renesas,r8a77961-rcar-usb2-clock-sel" if the device if a part of
> > + an R8A77961 SoC.
> > "renesas,rcar-gen3-usb2-clock-sel" for a generic R-Car Gen3
> > compatible device.
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2020-03-26 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 6:20 [PATCH] dt-bindings: clock: renesas,rcar-usb2-clock-sel: add r8a77961 support Yoshihiro Shimoda
2020-03-25 13:12 ` Geert Uytterhoeven
2020-03-26 2:21 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB454437073AE445BF608ECB2ED8CF0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).