RE: [PATCH v3 2/4] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add power-domains and resets properties

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 2/4] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add power-domains and resets properties
Date: Wed, 4 Mar 2020 06:29:03 +0000	[thread overview]
Message-ID: <TYAPR01MB4544BFFE2491F5A942C45277D8E50@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWbcDUThotTriK3mCB90FYODPpqPA0Ns50gQ0y8D7JdKw@mail.gmail.com>

Hi Geert-san,

Thank you for your review and I completely overlooked this email...

> From: Geert Uytterhoeven, Sent: Monday, November 18, 2019 7:12 PM
> 
> Hi Shimoda-san,
> 
> On Fri, Nov 1, 2019 at 8:03 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > This patch adds missing required properties of power-domains and resets.
> > Fortunately, no one has this device node for now, so that we don't
> > need to think of backward compatibility.
> >
> > Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> > @@ -43,6 +43,9 @@ Required properties:
> >   - The USB_EXTAL clock pin must be "usb_extal"
> >   - The USB_XTAL clock pin must be "usb_xtal"
> >  - #clock-cells: Must be 0
> > +- power-domains: A phandle and symbolic PM domain specifier.
> > +                 See power/renesas,rcar-sysc.txt.
> > +- resets: A list of phandles and specifier pairs.
> 
> Since there is more than one, I think it would be good to specify
> reset-names, too ("ehci_ohci" and "hs-usb-if").

I got it. I'll add reset-names.

Best regards,
Yoshihiro Shimoda

> The rest looks good to me.
> 
> >  Example (R-Car H3):
> >
> > @@ -54,4 +57,6 @@ Example (R-Car H3):
> >                          <&usb_extal>, <&usb_xtal>;
> >                 clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal";
> >                 #clock-cells = <0>;
> > +               power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> > +               resets = <&cpg 703>, <&cpg 704>;
> >         };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds