From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V4 02/18] pinctrl: tegra: add suspend and resume support
Date: Mon, 24 Jun 2019 12:46:28 +0300 [thread overview]
Message-ID: <a03ce644-5efd-e721-fb06-16de097171bb@gmail.com> (raw)
In-Reply-To: <1561345379-2429-3-git-send-email-skomatineni@nvidia.com>
24.06.2019 6:02, Sowjanya Komatineni пишет:
> This patch adds support for Tegra pinctrl driver suspend and resume.
>
> During suspend, context of all pinctrl registers are stored and
> on resume they are all restored to have all the pinmux and pad
> configuration for normal operation.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 47 ++++++++++++++++++++++++++++++++
> drivers/pinctrl/tegra/pinctrl-tegra.h | 4 +++
> drivers/pinctrl/tegra/pinctrl-tegra210.c | 6 ++++
> 3 files changed, 57 insertions(+)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index b03c465917b8..c0ba6fa63ad1 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -631,6 +631,38 @@ static void tegra_pinctrl_clear_parked_bits(struct tegra_pmx *pmx)
> }
> }
>
> +int __maybe_unused tegra_pinctrl_suspend(struct device *dev)
The "maybe_unused" attribute isn't needed for global functions because
compiler always assumes that such functions are used somewhere outside.
> +{
> + struct tegra_pmx *pmx = dev_get_drvdata(dev);
> + u32 *backup_regs = pmx->backup_regs;
> + u32 *regs;
> + unsigned int i, j;
> +
> + for (i = 0; i < pmx->nbanks; i++) {
> + regs = pmx->regs[i];
> + for (j = 0; j < pmx->reg_bank_size[i] / 4; j++)
> + *backup_regs++ = readl(regs++);
> + }
> +
> + return pinctrl_force_sleep(pmx->pctl);
> +}
> +
> +int __maybe_unused tegra_pinctrl_resume(struct device *dev)
> +{
> + struct tegra_pmx *pmx = dev_get_drvdata(dev);
> + u32 *backup_regs = pmx->backup_regs;
> + u32 *regs;
> + unsigned int i, j;
> +
> + for (i = 0; i < pmx->nbanks; i++) {
> + regs = pmx->regs[i];
> + for (j = 0; j < pmx->reg_bank_size[i] / 4; j++)
> + writel(*backup_regs++, regs++);
> + }
> +
> + return 0;
> +}
> +
> static bool gpio_node_has_range(const char *compatible)
> {
> struct device_node *np;
> @@ -655,6 +687,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
> int i;
> const char **group_pins;
> int fn, gn, gfn;
> + unsigned long backup_regs_size = 0;
>
> pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL);
> if (!pmx)
> @@ -707,6 +740,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
> res = platform_get_resource(pdev, IORESOURCE_MEM, i);
> if (!res)
> break;
> + backup_regs_size += resource_size(res);
> }
> pmx->nbanks = i;
>
> @@ -715,11 +749,24 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
> if (!pmx->regs)
> return -ENOMEM;
>
> + pmx->reg_bank_size = devm_kcalloc(&pdev->dev, pmx->nbanks,
> + sizeof(*pmx->reg_bank_size),
> + GFP_KERNEL);
> + if (!pmx->reg_bank_size)
> + return -ENOMEM;
> +
> + pmx->backup_regs = devm_kzalloc(&pdev->dev, backup_regs_size,
> + GFP_KERNEL);
> + if (!pmx->backup_regs)
> + return -ENOMEM;
> +
> for (i = 0; i < pmx->nbanks; i++) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, i);
> pmx->regs[i] = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(pmx->regs[i]))
> return PTR_ERR(pmx->regs[i]);
> +
> + pmx->reg_bank_size[i] = resource_size(res);
> }
>
> pmx->pctl = devm_pinctrl_register(&pdev->dev, &tegra_pinctrl_desc, pmx);
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.h b/drivers/pinctrl/tegra/pinctrl-tegra.h
> index 32642af3f871..65fcbf8c7579 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.h
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.h
> @@ -17,6 +17,8 @@ struct tegra_pmx {
>
> int nbanks;
> void __iomem **regs;
> + size_t *reg_bank_size;
> + u32 *backup_regs;
> };
>
> enum tegra_pinconf_param {
> @@ -195,4 +197,6 @@ struct tegra_pinctrl_soc_data {
>
> int tegra_pinctrl_probe(struct platform_device *pdev,
> const struct tegra_pinctrl_soc_data *soc_data);
> +int __maybe_unused tegra_pinctrl_suspend(struct device *dev);
> +int __maybe_unused tegra_pinctrl_resume(struct device *dev);
> #endif
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> index 617ad963f5ad..4616bbc2efba 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra210.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> @@ -1562,6 +1562,11 @@ static int tegra210_pinctrl_probe(struct platform_device *pdev)
> return tegra_pinctrl_probe(pdev, &tegra210_pinctrl);
> }
>
> +static const struct dev_pm_ops tegra_pinctrl_pm = {
> + .suspend = &tegra_pinctrl_suspend,
> + .resume = &tegra_pinctrl_resume
> +};
What about to move tegra_pinctrl_pm out into pinctrl-tegra.c to make it
common for all of the drivers?
next prev parent reply other threads:[~2019-06-24 9:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 3:02 [PATCH V4 00/18] SC7 entry and exit support for Tegra210 Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 01/18] irqchip: tegra: do not disable COP IRQ during suspend Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 02/18] pinctrl: tegra: add suspend and resume support Sowjanya Komatineni
2019-06-24 9:46 ` Dmitry Osipenko [this message]
2019-06-24 17:34 ` Sowjanya Komatineni
2019-06-26 10:08 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume Sowjanya Komatineni
2019-06-25 13:38 ` Linus Walleij
2019-06-26 17:06 ` Sowjanya Komatineni
2019-06-25 13:40 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 04/18] clk: tegra: save and restore divider rate Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 05/18] clk: tegra: pllout: save and restore pllout context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 06/18] clk: tegra: pll: save and restore pll context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 07/18] clk: tegra: save and restore CPU and System clocks context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 08/18] clk: tegra: support for saving and restoring OSC context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 09/18] clk: tegra: add suspend resume support for DFLL Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 10/18] clk: tegra: add save and restore context support for peripheral clocks Sowjanya Komatineni
2019-06-26 10:12 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 11/18] clk: tegra210: use fence_udelay during PLLU init Sowjanya Komatineni
2019-06-26 10:12 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 12/18] clk: tegra210: support for Tegra210 clocks suspend and resume Sowjanya Komatineni
2019-06-26 10:16 ` Thierry Reding
2019-06-26 16:46 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 13/18] soc/tegra: pmc: allow support for more tegra wake Sowjanya Komatineni
2019-06-24 8:15 ` Marc Zyngier
2019-06-24 16:21 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 14/18] soc/tegra: pmc: add pmc wake support for tegra210 Sowjanya Komatineni
2019-06-26 10:26 ` Thierry Reding
2019-06-26 16:27 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 15/18] arm64: tegra: enable wake from deep sleep on RTC alarm Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 16/18] soc/tegra: pmc: configure core power request polarity Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 17/18] soc/tegra: pmc: configure deep sleep control settings Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 18/18] arm64: dts: tegra210-p2180: Jetson TX1 SC7 timings Sowjanya Komatineni
2019-06-26 10:28 ` Thierry Reding
2019-06-26 16:28 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a03ce644-5efd-e721-fb06-16de097171bb@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=spatra@nvidia.com \
--cc=stefan@agner.ch \
--cc=talho@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).