From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
bjorn.andersson@linaro.org, mark.rutland@arm.com,
mturquette@baylibre.com, robh+dt@kernel.org
Cc: marc.w.gonzalez@free.fr, andy.gross@linaro.org,
david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: clock: Add support for the MSM8998 mmcc
Date: Tue, 5 Feb 2019 15:36:26 -0700 [thread overview]
Message-ID: <a048afe5-e87a-b539-1558-a26464622c1c@codeaurora.org> (raw)
In-Reply-To: <154940496255.169292.11279175475668034167@swboyd.mtv.corp.google.com>
On 2/5/2019 3:16 PM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-02-05 14:08:43)
>> On 2/5/2019 3:02 PM, Stephen Boyd wrote:
>>> Quoting Jeffrey Hugo (2019-01-30 08:35:59)
>>>> Document the multimedia clock controller found on MSM8998
>>>>
>>>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>>>> ---
>>>> Documentation/devicetree/bindings/clock/qcom,mmcc.txt | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>>>> index 8b0f784..ae85bca 100644
>>>> --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>>>> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>>>> @@ -10,11 +10,18 @@ Required properties :
>>>> "qcom,mmcc-msm8960"
>>>> "qcom,mmcc-msm8974"
>>>> "qcom,mmcc-msm8996"
>>>> + "qcom,mmcc-msm8998"
>>>>
>>>> - reg : shall contain base register location and length
>>>> - #clock-cells : shall contain 1
>>>> - #reset-cells : shall contain 1
>>>>
>>>> +For MSM8998 only:
>>>> + - clocks: a list of phandles and clock-specifier pairs,
>>>> + one for each entry in clock-names.
>>>> + - clock-names: "xo" for the xo clock,
>>>> + "gpll0" for the global pll 0 clock.
>>>
>>> Wouldn't the DSI plls also be listed here? And anything else that is
>>> external to this clock controller?
>>>
>>
>> We can't get the DSI plls from DT as far as I am aware (upstream). That
>> is why I mentioned in the cover letter we need to rely on the global
>> namespace.
>
> Why not? Because the DSI PLL isn't a clk provider? Or it doesn't have
> #clock-cells? Please try to use the DSI PLLs from DT or at least specify
> them in the binding as optional clocks that may not matter if DSI is not
> enabled for example.
I had thought that there wasn't a DT node that exposed those (I find it
very odd how the DSI PLLs get inited), but upon checking again, I see
what I have missed. I'll need to incorporate them now.
>
>>
>> Also, the DSI plls, etc present a chicken and egg situation, as the plls
>> require mmcc, and mmcc requires the plls. I forsee an unsolvable
>> EPROBE_DEFER issue.
>>
>
> We've "solved" that problem with orphan clks and the clk parent rewrite
> series. Maybe you can try it out to help flush out any bugs lurking
> there.
>
Thanks for the reference in your other reply. Will have a look.
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-02-05 22:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:35 [PATCH v1 0/4] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-01-30 16:35 ` [PATCH v1 1/4] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-02-05 22:01 ` Stephen Boyd
2019-02-05 22:15 ` Jeffrey Hugo
2019-02-05 22:32 ` Stephen Boyd
2019-02-05 22:37 ` Jeffrey Hugo
2019-02-06 13:55 ` Georgi Djakov
2019-02-06 17:04 ` Jeffrey Hugo
2019-01-30 16:35 ` [PATCH v1 2/4] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-02-05 22:02 ` Stephen Boyd
2019-02-05 22:08 ` Jeffrey Hugo
2019-02-05 22:16 ` Stephen Boyd
2019-02-05 22:36 ` Jeffrey Hugo [this message]
2019-01-30 16:36 ` [PATCH v1 3/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-02-05 22:06 ` Stephen Boyd
2019-02-05 22:12 ` Jeffrey Hugo
2019-02-05 22:16 ` Stephen Boyd
2019-01-30 16:36 ` [PATCH v1 4/4] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-02-05 22:03 ` Stephen Boyd
2019-02-05 22:10 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a048afe5-e87a-b539-1558-a26464622c1c@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).