From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF904C4361B for ; Wed, 9 Dec 2020 11:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A50B823B23 for ; Wed, 9 Dec 2020 11:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730447AbgLILak convert rfc822-to-8bit (ORCPT ); Wed, 9 Dec 2020 06:30:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730765AbgLILah (ORCPT ); Wed, 9 Dec 2020 06:30:37 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C98A8C061793 for ; Wed, 9 Dec 2020 03:29:56 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmxfG-0004Pq-QY; Wed, 09 Dec 2020 12:29:46 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kmxfF-0001N1-Jx; Wed, 09 Dec 2020 12:29:45 +0100 Message-ID: Subject: Re: [PATCH v5 12/21] riscv: Add Canaan Kendryte K210 reset controller From: Philipp Zabel To: Damien Le Moal , "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , "linus.walleij@linaro.org" , "palmer@dabbelt.com" , "sboyd@kernel.org" , "linux-gpio@vger.kernel.org" , "robh+dt@kernel.org" , "linux-clk@vger.kernel.org" Cc: "seanga2@gmail.com" Date: Wed, 09 Dec 2020 12:29:45 +0100 In-Reply-To: <57d4ae6e06551a56e41a4d50078ef51cbad67083.camel@wdc.com> References: <20201208073355.40828-1-damien.lemoal@wdc.com> <20201208073355.40828-13-damien.lemoal@wdc.com> <4d0a0c80e57b156b7d86dfca250285048ab30825.camel@pengutronix.de> <57d4ae6e06551a56e41a4d50078ef51cbad67083.camel@wdc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Damien, On Wed, 2020-12-09 at 05:26 +0000, Damien Le Moal wrote: [...] > I added COMPILE_TEST. I also removed the RISCV dependency since SOC_CANAAN > already depend on it (due to the SOC_EARLY_INIT_DECLARE() use in the sysctl > driver). Stricktly speaking, I think we could also remove the SOC_CANAAN > dependency for the reset driver, but I do not really see the point since it is > cannot be used for any other SoC. Thank you, this is fine. Depending on SOC_CANAAN is nice for users of other SoCs, as they aren't shown this option to enable a kernel driver that we know they don't need. regards Philipp