From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1FBC4321A for ; Sat, 29 Jun 2019 15:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 855D621726 for ; Sat, 29 Jun 2019 15:46:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fRVlUvQX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbfF2PqM (ORCPT ); Sat, 29 Jun 2019 11:46:12 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43379 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbfF2PqM (ORCPT ); Sat, 29 Jun 2019 11:46:12 -0400 Received: by mail-lf1-f68.google.com with SMTP id j29so5913296lfk.10; Sat, 29 Jun 2019 08:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n+gNnWdOpo6++IaBlEaAMij5pbe3mgcwedV0Vv4+onQ=; b=fRVlUvQXovrUlPYw7k2mzgm/PbfGIKtOwLbGID5Xz6XTSUrulJ0ZIzjDIEIMh4n0cY P3jZqaUuFvJlIP6NHtOMaWdhQaYXpBNJXZMwuwGUHshlQlkKTPVyeCV0x94tnsqO+vQs y6Bz0zLBuGqn726quhESW0fEXR7zh5Rv4krT6/CBv6udMy1QCoTUmH/gTfrlqN+TKPfU bDwu+5g8h58e8ppDQJc7shixnVoD38lb/99hHEQ6hmYZ0Jse5lIChpRrgdMAMG0EbAKm 1s/VEGZ8Stpo+t8D9HXtNf+8W/7N2mXkTetW5G30o406eRbjbcl2GDHWKJ8n/5OE44ET hKuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n+gNnWdOpo6++IaBlEaAMij5pbe3mgcwedV0Vv4+onQ=; b=hkDxSvmjy3aK9o377uBhFShrKjmlSoGrmVWqEH7naSCLmKXJJvYh/wJCyhjZgDRHbh T0S0/vOLsEatHcmhSc4BzOYvUIYY18JgnbfyY76WMj1Ues7Q+OcFADOlts3hgn70vKQx swkO/ITaSWE4BFod0kxhtjlhiU0Mj8d++dTOztE3oJehna9vyK4pM57TIzrJNopm74Mq kiuQYMLALaLk+KkXwokfs2e1fqxfcA5J6boP4vmORWDb7g3LR7tUH7ljTCHzgBG5QwS3 QIGt8InyOLMphsMb/fzBmNJbdrx4KDC0zsr+7k5arbkE3j7EsHl0R8bNBkOFYdywNpks hHog== X-Gm-Message-State: APjAAAWhLk3rYtE5RLAO47jURYmxO5EdcH2cfXeqd1tgiLUXDIDk8ieZ NzS2M00eO3oI3oOwfnZCTMjabPDR X-Google-Smtp-Source: APXvYqy7YekYw8JmgtfA4nsL3wHd1utlE8sfnJfjNNLZPLqCWDAidNBFFDhibWWYp6ElEtz9reX8TQ== X-Received: by 2002:a05:6512:51c:: with SMTP id o28mr8016798lfb.67.1561823169770; Sat, 29 Jun 2019 08:46:09 -0700 (PDT) Received: from [192.168.2.145] (ppp79-139-233-208.pppoe.spdop.ru. [79.139.233.208]) by smtp.googlemail.com with ESMTPSA id i2sm1790541ljc.96.2019.06.29.08.46.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Jun 2019 08:46:09 -0700 (PDT) Subject: Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org, devicetree@vger.kernel.org References: <1561687972-19319-1-git-send-email-skomatineni@nvidia.com> <1561687972-19319-3-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: Date: Sat, 29 Jun 2019 18:46:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <1561687972-19319-3-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds support for Tegra pinctrl driver suspend and resume. > > During suspend, context of all pinctrl registers are stored and > on resume they are all restored to have all the pinmux and pad > configuration for normal operation. > > Acked-by: Thierry Reding > Signed-off-by: Sowjanya Komatineni > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 52 ++++++++++++++++++++++++++++++++ > drivers/pinctrl/tegra/pinctrl-tegra.h | 3 ++ > drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 + > 3 files changed, 56 insertions(+) > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c > index 34596b246578..e7c0a1011cba 100644 > --- a/drivers/pinctrl/tegra/pinctrl-tegra.c > +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c > @@ -621,6 +621,43 @@ static void tegra_pinctrl_clear_parked_bits(struct tegra_pmx *pmx) > } > } > > +static int tegra_pinctrl_suspend(struct device *dev) > +{ > + struct tegra_pmx *pmx = dev_get_drvdata(dev); > + u32 *backup_regs = pmx->backup_regs; > + u32 *regs; > + unsigned int i, j; > + > + for (i = 0; i < pmx->nbanks; i++) { > + regs = pmx->regs[i]; > + for (j = 0; j < pmx->reg_bank_size[i] / 4; j++) > + *backup_regs++ = readl(regs++); > + } > + > + return pinctrl_force_sleep(pmx->pctl); > +} > + > +static int tegra_pinctrl_resume(struct device *dev) > +{ > + struct tegra_pmx *pmx = dev_get_drvdata(dev); > + u32 *backup_regs = pmx->backup_regs; > + u32 *regs; > + unsigned int i, j; > + > + for (i = 0; i < pmx->nbanks; i++) { > + regs = pmx->regs[i]; > + for (j = 0; j < pmx->reg_bank_size[i] / 4; j++) > + writel(*backup_regs++, regs++); > + } > + > + return 0; > +} > + > +const struct dev_pm_ops tegra_pinctrl_pm = { > + .suspend = &tegra_pinctrl_suspend, > + .resume = &tegra_pinctrl_resume > +}; Hm, so this are the generic platform-driver suspend-resume OPS here, which is very nice! But.. shouldn't pinctrl be resumed before the CLK driver (which is syscore_ops in this version of the series)? .. Given that "clock" function may need to be selected for some of the pins.