From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
catalin.marinas@arm.com, will@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, arnd@arndb.de, geert+renesas@glider.be,
neil.armstrong@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, rafal@milecki.pl, quic_srichara@quicinc.com,
quic_varada@quicinc.org, quic_wcheng@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Date: Sat, 17 Jun 2023 10:48:41 +0200 [thread overview]
Message-ID: <aca54f67-cc09-ff4f-93ca-6973d153db2c@linaro.org> (raw)
In-Reply-To: <20230615052746.GB22186@varda-linux.qualcomm.com>
On 15/06/2023 07:27, Varadarajan Narayanan wrote:
>>> + - enum:
>>> + - qcom,m31-usb-hsphy
>>
>> I am confused what's this. If m31 is coming from some IP block provider,
>> then you are using wrong vendor prefix.
>> https://www.m31tech.com/download_file/M31_USB.pdf
>>
>>
>>> + - qcom,ipq5332-m31-usb-hsphy
>>
>> This confuses me even more. IPQ m31?
>
> Will change this to m31,usb-hsphy and m31,ipq5332-usb-hsphy respectively.
> Will that be acceptable?
m31,ipq5332 seems wrong, as m31 did not create ipq5332. Does the m31
device have some name/version/model? If it is not really known, then I
would just propose to go with qcom,ipq5332-usb-hsphy.
Skip generic compatible ("usb-hsphy") entirely.
And then we have... existing bindings qcom,usb-hs-phy.yaml. Don't create
something similar with difference in the hyphen. Just use device
specific compatible thus device specific filename.
>
>>> +
>>> + reg:
>>> + description:
>>> + Offset and length of the M31 PHY register set
>>
>> Drop description, obvious.
>
> Ok.
>
>>> + maxItems: 2
>>> +
>>> + reg-names:
>>> + items:
>>> + - const: m31usb_phy_base
>>> + - const: qscratch_base
>>
>> Drop "_base" from both.
>
> Ok. Will drop qscratch_base. This is in the controller space.
> Should not come here.
Then drop reg-names entirely.
>
>>> +
>>> + phy_type:
>>> + oneOf:
>>> + - items:
>>> + - enum:
>>> + - utmi
>>> + - ulpi
>>
>> This does not belong to phy, but to USB node.
>
> This is used by the driver to set a bit during phy init. Hence
> have it as a replication of the USB node's entry. If this is not
> permissible, is there some way to get this from the USB node,
> or any other alternative mechanism?
Shouldn't USB controller choose what type of PHY type it wants?
>
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
>>> + hs_m31phy_0: hs_m31phy@5b00 {
>>
>> Node names should be generic. See also explanation and list of examples
>> in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> Also, no underscores in node names.
>
> Will change this as usbphy0:hs_m31phy@7b000
This does not solve my comments. I did not write "label" but "node name".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-17 8:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 10:56 [PATCH 0/9] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 1/9] dt-bindings: usb: dwc3: Add IPQ5332 compatible Varadarajan Narayanan
2023-06-07 18:33 ` Krzysztof Kozlowski
2023-06-15 4:15 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 2/9] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy Varadarajan Narayanan
2023-06-07 11:37 ` Rob Herring
2023-06-07 18:31 ` Krzysztof Kozlowski
2023-06-15 5:27 ` Varadarajan Narayanan
2023-06-17 8:48 ` Krzysztof Kozlowski [this message]
2023-06-20 9:32 ` Varadarajan Narayanan
2023-06-21 8:43 ` Krzysztof Kozlowski
2023-06-21 10:12 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 3/9] phy: qcom-m31: Introduce qcom,m31 USB phy driver Varadarajan Narayanan
2023-06-07 11:54 ` Konrad Dybcio
2023-06-07 12:29 ` Dmitry Baryshkov
2023-06-15 6:01 ` Varadarajan Narayanan
2023-06-15 5:49 ` Varadarajan Narayanan
2023-06-21 11:05 ` Vinod Koul
2023-06-07 10:56 ` [PATCH 4/9] clk: qcom: ipq5332: Fix USB related clock defines Varadarajan Narayanan
2023-06-07 11:19 ` Dmitry Baryshkov
2023-06-15 6:02 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 5/9] phy: qcom-m31: Introduce qcom,m31 USB phy Varadarajan Narayanan
2023-06-07 11:20 ` Dmitry Baryshkov
2023-06-07 18:37 ` Krzysztof Kozlowski
2023-06-15 6:05 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 6/9] phy: qcom: Add qcom,m31 USB phy driver Varadarajan Narayanan
2023-06-07 18:36 ` Krzysztof Kozlowski
2023-06-15 6:14 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 7/9] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-06-07 11:23 ` Dmitry Baryshkov
2023-06-15 6:26 ` Varadarajan Narayanan
2023-06-07 18:24 ` Konrad Dybcio
2023-06-15 6:52 ` Varadarajan Narayanan
2023-06-07 18:35 ` Krzysztof Kozlowski
2023-06-15 7:17 ` Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 8/9] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-06-07 10:56 ` [PATCH 9/9] arm64: defconfig: Enable QCOM M31 USB phy driver Varadarajan Narayanan
2023-06-07 18:36 ` Krzysztof Kozlowski
2023-06-15 8:37 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aca54f67-cc09-ff4f-93ca-6973d153db2c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_varada@quicinc.org \
--cc=quic_wcheng@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).