From: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<jassisinghbrar@gmail.com>, <mathieu.poirier@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<quic_eberman@quicinc.com>, <quic_mojha@quicinc.com>,
<kvalo@kernel.org>, <loic.poulain@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_poovendh@quicinc.com>, <quic_varada@quicinc.com>,
<quic_devipriy@quicinc.com>
Subject: Re: [PATCH V2 11/13] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd
Date: Mon, 5 Jun 2023 11:05:15 +0530 [thread overview]
Message-ID: <adb4716f-9fa8-9b37-0a06-5c5e19307925@quicinc.com> (raw)
In-Reply-To: <a33363d2-a0a8-f8c1-fbc0-f7a5422d07a9@linaro.org>
On 5/30/2023 4:35 PM, Krzysztof Kozlowski wrote:
> On 22/05/2023 00:28, Manikanta Mylavarapu wrote:
>> Enable nodes required for multipd remoteproc bring up
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>
> It is "dts". Not "dtsi".
>
Sure, I will update to 'dtsi'.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>> Changes in V2:
>> - Corrected syntax like alignmnet and kept nodes in sorted order.
>> - Covered entire TCSR region.
>> - Added 'firmware-name' property.
>>
>> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 140 ++++++++++++++++++++++++++
>> 1 file changed, 140 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> index 9f13d2dcdfd5..3772d54d89e4 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> @@ -85,6 +85,18 @@
>> reg = <0x0 0x4ac00000 0x0 0x200000>;
>> no-map;
>> };
>> +
>> + q6_region: wcnss@4b000000 {
>> + reg = <0x0 0x4b000000 0x0 0x1700000>;
>> + no-map;
>> + };
>> +
>> + smem@4ab00000 {
>> + compatible = "qcom,smem";
>> + reg = <0x0 0x4ab00000 0x0 0x100000>;
>> + hwlocks = <&tcsr_mutex 0>;
>> + no-map;
>> + };
>> };
>>
>> soc: soc@0 {
>> @@ -128,6 +140,12 @@
>> #power-domain-cells = <1>;
>> };
>>
>> + tcsr_mutex: hwlock@1905000 {
>> + compatible = "qcom,tcsr-mutex";
>> + reg = <0x01905000 0x20000>;
>> + #hwlock-cells = <1>;
>> + };
>> +
>> sdhc_1: mmc@7804000 {
>> compatible = "qcom,ipq5018-sdhci", "qcom,sdhci-msm-v5";
>> reg = <0x7804000 0x1000>;
>> @@ -181,6 +199,14 @@
>> };
>> };
>>
>> + apcs_glb: mailbox@b111000 {
>> + compatible = "qcom,ipq5018-apcs-apps-global",
>> + "qcom,ipq6018-apcs-apps-global";
>> + reg = <0x0b111000 0x1000>;
>> + #clock-cells = <1>;
>> + #mbox-cells = <1>;
>> + };
>> +
>> timer@b120000 {
>> compatible = "arm,armv7-timer-mem";
>> reg = <0x0b120000 0x1000>;
>> @@ -238,6 +264,96 @@
>> status = "disabled";
>> };
>> };
>> +
>> + q6v5_wcss: remoteproc@cd00000 {
>> + compatible = "qcom,ipq5018-q6-mpd";
>> + reg = <0x0cd00000 0x4040>;
>> + firmware-name = "IPQ5018/q6_fw.mdt",
>> + "IPQ5018/m3_fw.mdt",
>> + "qcn6122/m3_fw.mdt";
>> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>,
>> + <&wcss_smp2p_in 0 0>,
>> + <&wcss_smp2p_in 1 0>,
>> + <&wcss_smp2p_in 2 0>,
>> + <&wcss_smp2p_in 3 0>;
>> + interrupt-names = "wdog",
>> + "fatal",
>> + "ready",
>> + "handover",
>> + "stop-ack";
>> +
>> + qcom,smem-states = <&wcss_smp2p_out 0>,
>> + <&wcss_smp2p_out 1>;
>> + qcom,smem-state-names = "shutdown",
>> + "stop";
>> + memory-region = <&q6_region>;
>> +
>> + glink-edge {
>> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>;
>> + label = "rtr";
>> + qcom,remote-pid = <1>;
>> + mboxes = <&apcs_glb 8>;
>> + };
>> +
>> + pd-1 {
>> + compatible = "qcom,ipq5018-wcss-ahb-mpd";
>> + firmware-name = "IPQ5018/q6_fw.mdt";
>> + interrupts-extended = <&wcss_smp2p_in 8 0>,
>> + <&wcss_smp2p_in 9 0>,
>> + <&wcss_smp2p_in 12 0>,
>> + <&wcss_smp2p_in 11 0>;
>
> What "0" stands for?
>
0 means IRQ_NONE. These are software interrupts (register write),
so we have configured to 0. I will replace 0 with IRQ_NONE.
Thanks & Regards,
Manikanta.
>> + interrupt-names = "fatal",
>> + "ready",
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-06-05 5:35 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 22:28 [PATCH V2 00/13] Add multipd remoteproc support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model Manikanta Mylavarapu
2023-05-30 10:46 ` Krzysztof Kozlowski
2023-06-05 5:58 ` Manikanta Mylavarapu
2023-05-30 10:58 ` Krzysztof Kozlowski
2023-06-05 8:03 ` Manikanta Mylavarapu
2023-06-05 12:02 ` Manikanta Mylavarapu
2023-06-06 6:14 ` Krzysztof Kozlowski
2023-06-06 12:11 ` Manikanta Mylavarapu
2023-06-06 13:49 ` Kalle Valo
2023-06-07 8:10 ` Manikanta Mylavarapu
2023-06-07 8:27 ` Krzysztof Kozlowski
2023-06-14 11:43 ` Manikanta Mylavarapu
2023-06-14 12:49 ` Manikanta Mylavarapu
2023-06-14 13:59 ` Krzysztof Kozlowski
2023-06-21 11:39 ` Manikanta Mylavarapu
2023-06-24 7:19 ` Krzysztof Kozlowski
2023-06-30 7:12 ` Manikanta Mylavarapu
2023-07-01 10:51 ` Krzysztof Kozlowski
2023-07-18 12:10 ` Manikanta Mylavarapu
2023-06-08 12:59 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 02/13] dt-bindings: mailbox: qcom: Add IPQ5018 APCS compatible Manikanta Mylavarapu
2023-05-30 10:59 ` Krzysztof Kozlowski
2023-05-21 22:28 ` [PATCH V2 03/13] dt-bindings: arm: qcom: Document the Qualcomm rdp432-c1 board Manikanta Mylavarapu
2023-05-30 10:59 ` Krzysztof Kozlowski
2023-06-05 5:29 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 04/13] dt-bindings: clock: qcom: gcc-ipq5018: remove q6 clocks macros Manikanta Mylavarapu
2023-05-30 11:01 ` Krzysztof Kozlowski
2023-06-01 18:55 ` Robert Marko
2023-06-05 6:22 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 05/13] dt-bindings: clock: qcom: gcc-ipq9574: remove q6 bring up clock macros Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 06/13] clk: qcom: ipq5018: remove q6 bring up clocks Manikanta Mylavarapu
2023-05-30 11:03 ` Krzysztof Kozlowski
2023-06-06 12:17 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 07/13] clk: qcom: ipq9574: " Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 08/13] firmware: qcom_scm: ipq5018: Add WCSS AHB pd support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 09/13] remoteproc: qcom: q6v5: Add multipd interrupts support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 10/13] remoteproc: qcom: Add Hexagon based multipd rproc driver Manikanta Mylavarapu
2023-06-24 7:28 ` Krzysztof Kozlowski
[not found] ` <54f06704-a849-7049-5956-31cb4765a1eb@quicinc.com>
2023-06-30 10:29 ` Manikanta Mylavarapu
2023-07-01 10:55 ` Krzysztof Kozlowski
2023-07-18 12:10 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 11/13] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd Manikanta Mylavarapu
2023-05-30 11:05 ` Krzysztof Kozlowski
2023-06-05 5:35 ` Manikanta Mylavarapu [this message]
2023-06-05 5:38 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 12/13] arm64: dts: qcom: ipq5018: Add RDP432-c1 board support Manikanta Mylavarapu
2023-05-30 11:06 ` Krzysztof Kozlowski
2023-06-08 12:33 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 13/13] arm64: dtsi: qcom: ipq9574: Add nodes to bring up multipd Manikanta Mylavarapu
2023-06-24 7:01 ` Krzysztof Kozlowski
[not found] ` <15bdbd23-9066-ee20-1e29-1d086340c133@quicinc.com>
2023-06-30 7:11 ` Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb4716f-9fa8-9b37-0a06-5c5e19307925@quicinc.com \
--to=quic_mmanikan@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).