From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F34C3A59D for ; Fri, 16 Aug 2019 20:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 660092077C for ; Fri, 16 Aug 2019 20:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbfHPUl7 (ORCPT ); Fri, 16 Aug 2019 16:41:59 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:43170 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727545AbfHPUl7 (ORCPT ); Fri, 16 Aug 2019 16:41:59 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hyj2k-0000GR-1V; Fri, 16 Aug 2019 22:41:50 +0200 Date: Fri, 16 Aug 2019 22:41:49 +0200 (CEST) From: Thomas Gleixner To: Paul Burton cc: YueHaibing , "jason@lakedaemon.net" , "maz@kernel.org" , "paul@crapouillou.net" , "malat@debian.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building In-Reply-To: <20190816201857.46hqlsezqkxdabd7@pburton-laptop> Message-ID: References: <20190813015602.30576-1-yuehaibing@huawei.com> <20190816201857.46hqlsezqkxdabd7@pburton-laptop> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 16 Aug 2019, Paul Burton wrote: > On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote: > > On Tue, 13 Aug 2019, YueHaibing wrote: > > > > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is > > > not selected, it fails: > > > > > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade': > > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip' > > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init': > > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops' > > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips' > > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip' > > > > > > select GENERIC_IRQ_CHIP to fix this. > > > > > > Reported-by: Hulk Robot > > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") > > > > git show 9536eba03ec7 > > > > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in > > the working tree. > > The referenced patch is in mips-next - can I get your Ack to apply this > there too? Sure. Acked-by-me :)