linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tero Kristo <t-kristo@ti.com>, <linux-clk@vger.kernel.org>,
	<sboyd@kernel.org>, <mturquette@baylibre.com>
Subject: Re: [PATCH 0/4] clk: debugfs: add some simple debug functionality
Date: Tue, 1 Oct 2019 12:21:15 +0300	[thread overview]
Message-ID: <b8ec93f6-4dcf-2ff1-ff64-6da4ebd7f553@ti.com> (raw)
In-Reply-To: <20191001090202.26346-1-t-kristo@ti.com>

On 01/10/2019 12:01, Tero Kristo wrote:
> Hi,
> 
> I have been using a variation of these patches myself for several years
> for debugging / testing different clock issues. Basically what I do here
> is extend the functionality of debugfs to allow write access to certain
> properties, like rate, enable / prepare counts, mux parents.
> 
> This allows simple testing of new features or debugging directly from
> userspace. The functionality is hidden behind a Kconfig option because
> it can be rather dangerous to allow access to these unconditionally if
> the user does not know what they are doing.
> 
> Any thoughts?

I haven't reviewed the patches, but I've been using (earlier versions 
of) these, and at least for me they were of great value finding clock 
related issues.

So what it's worth, +1 from me.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  parent reply	other threads:[~2019-10-01  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01  9:01 [PATCH 0/4] clk: debugfs: add some simple debug functionality Tero Kristo
2019-10-01  9:01 ` [PATCH 1/4] clk: debug: add support for setting clk_rate from debugfs Tero Kristo
2019-10-01  9:02 ` [PATCH 2/4] clk: debug: add support for enable/disable/prep/un-prep " Tero Kristo
2019-10-01  9:02 ` [PATCH 3/4] clk: ti: mux: add debugfs support for read/write of parent ID Tero Kristo
2019-10-01  9:02 ` [PATCH 4/4] clk: keystone: sci-clk: " Tero Kristo
2019-10-01  9:21 ` Tomi Valkeinen [this message]
2020-01-06  3:13 ` [PATCH 0/4] clk: debugfs: add some simple debug functionality Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8ec93f6-4dcf-2ff1-ff64-6da4ebd7f553@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).