linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
	Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
	Stephen McCamant <smccaman@umn.edu>
Subject: clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll()
Date: Sat, 12 Oct 2019 16:17:03 +0200	[thread overview]
Message-ID: <c1bc5e4d-0802-4485-2c07-248bab2a3330@web.de> (raw)

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “_samsung_clk_register_pll” contains also a call
of the function “kmemdup”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/samsung/clk-pll.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1275
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/samsung/clk-pll.c#L1275

* Do you find the usage of the format string “%s: could not allocate
  rate table for %s\n” still appropriate at this place?

* Is there a need to adjust the error handling here?

Regards,
Markus

             reply	other threads:[~2019-10-12 14:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20191012141739epcas3p31e41c151b30d49c94aeb933aa42dc9f7@epcas3p3.samsung.com>
2019-10-12 14:17 ` Markus Elfring [this message]
2019-10-14  6:55   ` clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll() Chanwoo Choi
2019-10-14  8:05     ` Markus Elfring
2019-10-12 14:17 Markus Elfring
2019-10-15 14:49 ` Tomasz Figa
2019-10-15 17:55   ` Markus Elfring
2019-10-16 11:43     ` Tomasz Figa
2019-10-16 11:58       ` Markus Elfring
2019-10-15 17:55   ` Markus Elfring
2019-10-16 10:55   ` Markus Elfring
2019-10-16 11:44     ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1bc5e4d-0802-4485-2c07-248bab2a3330@web.de \
    --to=markus.elfring@web.de \
    --cc=cw00.choi@samsung.com \
    --cc=emamd001@umn.edu \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pakki001@umn.edu \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=smccaman@umn.edu \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).