linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: cs2000-cp: Document aux-output-source
Date: Thu, 17 Jun 2021 15:10:07 +0200	[thread overview]
Message-ID: <ceb82b22-6657-0003-561c-cf4d72b9d5d7@zonque.org> (raw)
In-Reply-To: <CAMuHMdUmEWNCj6J43jwxE67K=ksRy53Eb9B82HjDfC++-YLw9g@mail.gmail.com>

Hi Geert,

Thanks for looking into this patch!

On 6/11/21 2:18 PM, Geert Uytterhoeven wrote:
>> +  cirrus,aux-output-source:
>> +    description:
>> +      Specfies the function of the auxililary clock output pin
> 
> Specifies ... auxiliary
> 
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum:
>> +      - 0 # CS2000CP_AUX_OUTPUT_REF_CLK:  ref_clk input
>> +      - 1 # CS2000CP_AUX_OUTPUT_CLK_IN:   clk_in input
>> +      - 2 # CS2000CP_AUX_OUTPUT_CLK_OUT:  clk_out output
>> +      - 3 # CS2000CP_AUX_OUTPUT_PLL_LOCK: pll lock status
> 
> Should the default be documented? "default: 0"?

Both addressed. I will send a new series soon that supersedes this one
and carries some more changes.


Daniel

  reply	other threads:[~2021-06-17 13:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 20:15 [PATCH v2 0/3] clk: cs2000-cp: make aux output pin configurable Daniel Mack
2021-05-19 20:15 ` [PATCH v2 1/3] dt-bindings: clock: convert cs2000-cp bindings to yaml Daniel Mack
2021-05-21  1:59   ` Rob Herring
2021-05-19 20:15 ` [PATCH v2 2/3] dt-bindings: clock: cs2000-cp: Document aux-output-source Daniel Mack
2021-05-21  2:00   ` Rob Herring
2021-06-02 11:13     ` Daniel Mack
2021-06-11 12:18   ` Geert Uytterhoeven
2021-06-17 13:10     ` Daniel Mack [this message]
2021-05-19 20:15 ` [PATCH v2 3/3] clk: cs2000-cp: Make aux output function controllable Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ceb82b22-6657-0003-561c-cf4d72b9d5d7@zonque.org \
    --to=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).