From: Jian Hu <jian.hu@amlogic.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Jianxin Pan <jianxin.pan@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Qiufang Dai <qiufang.dai@amlogic.com>,
<linux-clk@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: clock: meson: add A1 clock controller bindings
Date: Fri, 27 Sep 2019 14:08:34 +0800 [thread overview]
Message-ID: <d9b23872-3d6f-ddb0-d44b-174fb2984232@amlogic.com> (raw)
In-Reply-To: <1j4l10motk.fsf@starbuckisacylon.baylibre.com>
Hi, Jerome
Thank you for review.
On 2019/9/25 22:29, Jerome Brunet wrote:
> On Wed 25 Sep 2019 at 19:44, Jian Hu <jian.hu@amlogic.com> wrote:
>
> In addition to the comment expressed by Stephen on patch 2
>
got it.
>> Add the documentation to support Amlogic A1 clock driver,
>> and add A1 clock controller bindings.
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> ---
>> .../devicetree/bindings/clock/amlogic,a1-clkc.yaml | 65 +++++++++++++
>> include/dt-bindings/clock/a1-clkc.h | 102 +++++++++++++++++++++
>> 2 files changed, 167 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml
>> create mode 100644 include/dt-bindings/clock/a1-clkc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml
>> new file mode 100644
>> index 0000000..f012eb2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml
>> @@ -0,0 +1,65 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>> +/*
>> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>> + */
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic Meson A1 Clock Control Unit Device Tree Bindings
>> +
>> +maintainers:
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> + - Jerome Brunet <jbrunet@baylibre.com>
>> + - Jian Hu <jian.hu@jian.hu.com>
>> +
>> +properties:
>> + compatible:
>> + - enum:
>> + - amlogic,a1-clkc
>> +
>> + reg:
>> + minItems: 1
>> + maxItems: 3
>> + items:
>> + - description: peripheral registers
>> + - description: cpu registers
>> + - description: pll registers
>> +
>> + reg-names:
>> + items:
>> + - const: peripheral
>> + - const: pll
>> + - const: cpu
>> +
>> + clocks:
>> + maxItems: 1
>> + items:
>> + - description: Input Oscillator (usually at 24MHz)
>> +
>> + clock-names:
>> + maxItems: 1
>> + items:
>> + - const: xtal
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - clocks
>> + - clock-names
>> + - "#clock-cells"
>> +
>> +examples:
>> + - |
>> + clkc: clock-controller {
>> + compatible = "amlogic,a1-clkc";
>> + reg = <0x0 0xfe000800 0x0 0x100>,
>> + <0x0 0xfe007c00 0x0 0x21c>,
>> + <0x0 0xfd000080 0x0 0x20>;
>> + reg-names = "peripheral", "pll", "cpu";
>
> I'm sorry but I don't agree with this. You are trying to regroup several
> controllers into one with this, and it is not OK
>
> By the looks of it there are 3 different controllers, including one you
> did not implement in the driver.
>
Yes, In A1, the clock registers include three regions.
I agree with your opinion. I will implement the two clock drivers of
peripheral and plls first in PATCH V2. And CPU clock driver will be sent
after the patches are merged.
>> + clocks = <&xtal;
>> + clock-names = "xtal";
>> + #clock-cells = <1>;
>
> .
>
next prev parent reply other threads:[~2019-09-27 6:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 11:44 [PATCH 0/2] add Amlogic A1 clock controller driver Jian Hu
2019-09-25 11:44 ` [PATCH 1/2] dt-bindings: clock: meson: add A1 clock controller bindings Jian Hu
2019-09-25 14:29 ` Jerome Brunet
2019-09-27 6:08 ` Jian Hu [this message]
2019-09-27 20:10 ` Rob Herring
2019-12-18 7:30 ` Jian Hu
2019-09-25 11:44 ` [PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver Jian Hu
2019-09-25 13:12 ` Stephen Boyd
2019-09-27 3:11 ` Jian Hu
2019-09-27 12:56 ` Jerome Brunet
2019-09-29 6:15 ` Jian Hu
2019-09-25 15:09 ` Jerome Brunet
2019-09-27 9:52 ` Jian Hu
2019-09-27 13:32 ` Jerome Brunet
2019-09-29 9:38 ` Jian Hu
2019-10-08 8:03 ` Jian Hu
2019-10-11 7:39 ` Jerome Brunet
2019-10-14 13:42 ` Jian Hu
2019-10-14 14:55 ` Jerome Brunet
2019-10-18 3:42 ` Jian Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b23872-3d6f-ddb0-d44b-174fb2984232@amlogic.com \
--to=jian.hu@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).