Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: <Nicolas.Ferre@microchip.com>
To: <alexandre.belloni@bootlin.com>, <sboyd@kernel.org>
Cc: <mturquette@baylibre.com>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: at91: fix masterck name
Date: Fri, 8 Feb 2019 15:53:47 +0000
Message-ID: <db6b542f-add1-af4c-e3f1-ce293042f375@microchip.com> (raw)
In-Reply-To: <20190208144059.29861-1-alexandre.belloni@bootlin.com>

On 08/02/2019 at 15:40, Alexandre Belloni wrote:
> The master clock is actually named masterck earlier in the driver. Having
> "mck" in the parent list means that it can never be selected.
> 
> Fixes: 1eabdc2f9dd8 ("clk: at91: add at91sam9x5 PMCs driver")
> Fixes: a2038077de9a ("clk: at91: add sama5d2 PMC driver")
> Fixes: 084b696bb509 ("clk: at91: add sama5d4 pmc driver")
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/clk/at91/at91sam9x5.c | 2 +-
>   drivers/clk/at91/sama5d2.c    | 4 ++--
>   drivers/clk/at91/sama5d4.c    | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/at91/at91sam9x5.c b/drivers/clk/at91/at91sam9x5.c
> index 2fe225a697df..d55a151cb7f5 100644
> --- a/drivers/clk/at91/at91sam9x5.c
> +++ b/drivers/clk/at91/at91sam9x5.c
> @@ -210,7 +210,7 @@ static void __init at91sam9x5_pmc_setup(struct device_node *np,
>   	parent_names[1] = "mainck";
>   	parent_names[2] = "plladivck";
>   	parent_names[3] = "utmick";
> -	parent_names[4] = "mck";
> +	parent_names[4] = "masterck";
>   	for (i = 0; i < 2; i++) {
>   		char name[6];
>   
> diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c
> index d69ad96fe988..cd0ef7274fdb 100644
> --- a/drivers/clk/at91/sama5d2.c
> +++ b/drivers/clk/at91/sama5d2.c
> @@ -240,7 +240,7 @@ static void __init sama5d2_pmc_setup(struct device_node *np)
>   	parent_names[1] = "mainck";
>   	parent_names[2] = "plladivck";
>   	parent_names[3] = "utmick";
> -	parent_names[4] = "mck";
> +	parent_names[4] = "masterck";
>   	for (i = 0; i < 3; i++) {
>   		char name[6];
>   
> @@ -291,7 +291,7 @@ static void __init sama5d2_pmc_setup(struct device_node *np)
>   	parent_names[1] = "mainck";
>   	parent_names[2] = "plladivck";
>   	parent_names[3] = "utmick";
> -	parent_names[4] = "mck";
> +	parent_names[4] = "masterck";
>   	parent_names[5] = "audiopll_pmcck";
>   	for (i = 0; i < ARRAY_SIZE(sama5d2_gck); i++) {
>   		hw = at91_clk_register_generated(regmap, &pmc_pcr_lock,
> diff --git a/drivers/clk/at91/sama5d4.c b/drivers/clk/at91/sama5d4.c
> index e358be7f6c8d..b645a9d59cdb 100644
> --- a/drivers/clk/at91/sama5d4.c
> +++ b/drivers/clk/at91/sama5d4.c
> @@ -207,7 +207,7 @@ static void __init sama5d4_pmc_setup(struct device_node *np)
>   	parent_names[1] = "mainck";
>   	parent_names[2] = "plladivck";
>   	parent_names[3] = "utmick";
> -	parent_names[4] = "mck";
> +	parent_names[4] = "masterck";
>   	for (i = 0; i < 3; i++) {
>   		char name[6];
>   
> 


-- 
Nicolas Ferre

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 14:40 Alexandre Belloni
2019-02-08 15:53 ` Nicolas.Ferre [this message]
2019-02-20 11:27   ` Nicolas.Ferre
2019-02-20 19:43 ` Stephen Boyd

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db6b542f-add1-af4c-e3f1-ce293042f375@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox