From: Daniel Baluta <daniel.baluta@nxp.com>
To: Peng Fan <peng.fan@nxp.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Abel Vesa <abel.vesa@nxp.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
Alice Guo <alice.guo@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"will@kernel.org" <will@kernel.org>
Subject: Re: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed
Date: Wed, 13 Nov 2019 12:35:57 +0000 [thread overview]
Message-ID: <e4fb1c1506c5a5566ed20b564970a97eb6b6c94d.camel@nxp.com> (raw)
In-Reply-To: <AM0PR04MB44817EBFF8CF1BB6E2CE369D88760@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Wed, 2019-11-13 at 12:15 +0000, Peng Fan wrote:
> Hi Daniel,
>
> > Subject: Re: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed
> >
> >
> > On Wed, 2019-11-13 at 07:24 +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > It not make sense to use writel, use relaxed variant.
> > >
> >
> > Hi Peng,
> >
> > Please explain why this change is needed.
>
> writel has a barrier, however that barrier is not needed,
> because device memory access is in order and clk driver
> has spin_lock or other lock to make sure write finished.
>
Make sure you add this in the commit message for v2 :).
next prev parent reply other threads:[~2019-11-13 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 7:24 [PATCH 0/2] clk: imx: pll14xx: io relaxed fix Peng Fan
2019-11-13 7:24 ` [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed Peng Fan
2019-11-13 11:10 ` Daniel Baluta
2019-11-13 12:15 ` Peng Fan
2019-11-13 12:35 ` Daniel Baluta [this message]
2019-11-13 7:24 ` [PATCH 2/2] clk: imx: pll14xx: use readl to force write completed Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4fb1c1506c5a5566ed20b564970a97eb6b6c94d.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=alice.guo@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).