From: Michael Walle <michael@walle.cc>
To: Rob Herring <robh@kernel.org>
Cc: Wen He <wen.he_1@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Li Yang <leoyang.li@nxp.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v10 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings
Date: Mon, 02 Dec 2019 22:32:16 +0100 [thread overview]
Message-ID: <e876f247860d728498df37705e7dfba2@walle.cc> (raw)
In-Reply-To: <20191202184758.GA8408@bogus>
Am 2019-12-02 19:47, schrieb Rob Herring:
> On Wed, Nov 27, 2019 at 06:15:24PM +0800, Wen He wrote:
>> LS1028A has a clock domain PXLCLK0 used for provide pixel clocks to
>> Display
>> output interface. Add a YAML schema for this.
>>
>> Signed-off-by: Wen He <wen.he_1@nxp.com>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> change in v10:
>> - Add optional feild 'vco-frequency'.
>>
>> .../devicetree/bindings/clock/fsl,plldig.yaml | 54
>> +++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/clock/fsl,plldig.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
>> b/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
>> new file mode 100644
>> index 000000000000..ee5b5c61a471
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.yaml
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/clock/fsl,plldig.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NXP QorIQ Layerscape LS1028A Display PIXEL Clock Binding
>> +
>> +maintainers:
>> + - Wen He <wen.he_1@nxp.com>
>> +
>> +description: |
>> + NXP LS1028A has a clock domain PXLCLK0 used for the Display output
>> + interface in the display core, as implemented in TSMC CLN28HPM PLL.
>> + which generate and offers pixel clocks to Display.
>> +
>> +properties:
>> + compatible:
>> + const: fsl,ls1028a-plldig
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#clock-cells':
>> + const: 0
>> +
>> + vco-frequency:
>
> Needs vendor prefix and unit suffix:
>
> fsl,vco-hz
>
> Or you could perhaps just use 'clock-frequency'.
Ok, fsl,vco-hz sounds good. clock-frequency sounds like it is the
output.
-michael
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>> + description: Optional for VCO frequency of the PLL in Hertz.
>> + The VCO frequency of this PLL cannot be changed during
>> runtime
>> + only at startup. Therefore, the output frequencies are very
>> + limited and might not even closely match the requested
>> frequency.
>> + To work around this restriction the user may specify its own
>> + desired VCO frequency for the PLL. The frequency has to be in
>> the
>> + range of 650000000 to 1300000000.
>> + If not set, the default frequency is 1188000000.
>
> A bunch of constraints you've listed here that should be schema rather
> than freeform text:
>
> minimum: 650000000
> maximum: 1300000000
> default: 1188000000
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - '#clock-cells'
>> +
>> +examples:
>> + # Display PIXEL Clock node:
>> + - |
>> + dpclk: clock-display@f1f0000 {
>> + compatible = "fsl,ls1028a-plldig";
>> + reg = <0x0 0xf1f0000 0x0 0xffff>;
>> + #clock-cells = <0>;
>> + clocks = <&osc_27m>;
>> + };
>> +
>> +...
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2019-12-02 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 10:15 [v10 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings Wen He
2019-11-27 10:15 ` [v10 2/2] clk: ls1028a: Add clock driver for Display output interface Wen He
2019-12-02 18:47 ` [v10 1/2] dt/bindings: clk: Add YAML schemas for LS1028A Display Clock bindings Rob Herring
2019-12-02 21:32 ` Michael Walle [this message]
2019-12-04 1:36 ` [EXT] " Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e876f247860d728498df37705e7dfba2@walle.cc \
--to=michael@walle.cc \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).