From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org
Cc: konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, mturquette@baylibre.com,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 07/11] clk: qcom: mmcc-msm8998: Set CLK_GET_RATE_NOCACHE to pixel/byte clks
Date: Tue, 9 Feb 2021 14:19:37 +0100 [thread overview]
Message-ID: <eae79cc3-f857-d39e-5257-c6aa263eaf07@somainline.org> (raw)
In-Reply-To: <161280847912.76967.9613917615673032246@swboyd.mtv.corp.google.com>
Il 08/02/21 19:21, Stephen Boyd ha scritto:
> Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:55)
>> The pixel and byte clocks rate should not be cached, as a VCO shutdown
>> may clear the frequency setup and this may not be set again due to the
>> cached rate being present.
>> This will also be useful when shadow clocks will be implemented in
>> the DSI PLL for seamless timing/resolution switch.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>> ---
>> drivers/clk/qcom/mmcc-msm8998.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> We didn't do this on sdm845, so I'm not going to apply this patch. The
> rate caching thing is a problem with the display driver that should be
> fixed some other way vs. setting nocache here.
>
Ok, I agree.
next prev parent reply other threads:[~2021-02-09 13:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 22:10 [PATCH v2 00/11] Clock fixes for MSM8998 GCC, MMCC, GPUCC AngeloGioacchino Del Regno
2021-01-14 22:10 ` [PATCH v2 01/11] dt-bindings: clocks: gcc-msm8998: Add GCC_MMSS_GPLL0_CLK definition AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 02/11] clk: qcom: gcc-msm8998: Wire up gcc_mmss_gpll0 clock AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 03/11] dt-bindings: clock: gcc-msm8998: Add HMSS_GPLL0_CLK_SRC definition AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 04/11] clk: qcom: gcc-msm8998: Add missing hmss_gpll0_clk_src clock AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 05/11] clk: qcom: gcc-msm8998: Mark gpu_cfg_ahb_clk as critical AngeloGioacchino Del Regno
2021-01-14 22:37 ` Jeffrey Hugo
2021-01-14 23:05 ` AngeloGioacchino Del Regno
2021-01-15 0:09 ` Jeffrey Hugo
2021-02-08 18:18 ` Stephen Boyd
2021-02-09 13:20 ` AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 06/11] clk: qcom: gcc-msm8998: Fix Alpha PLL type for all GPLLs AngeloGioacchino Del Regno
2021-02-08 18:19 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 07/11] clk: qcom: mmcc-msm8998: Set CLK_GET_RATE_NOCACHE to pixel/byte clks AngeloGioacchino Del Regno
2021-02-08 18:20 ` Stephen Boyd
2021-02-08 18:21 ` Stephen Boyd
2021-02-09 13:19 ` AngeloGioacchino Del Regno [this message]
2021-01-14 22:10 ` [PATCH v2 08/11] clk: qcom: mmcc-msm8998: Add hardware clockgating registers to some clks AngeloGioacchino Del Regno
2021-02-08 18:21 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 09/11] clk: qcom: mmcc-msm8998: Set bimc_smmu_gdsc always on AngeloGioacchino Del Regno
2021-02-08 18:22 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 10/11] clk: qcom: gpucc-msm8998: Add resets, cxc, fix flags on gpu_gx_gdsc AngeloGioacchino Del Regno
2021-02-08 18:22 ` Stephen Boyd
2021-01-14 22:10 ` [PATCH v2 11/11] clk: qcom: gpucc-msm8998: Allow fabia gpupll0 rate setting AngeloGioacchino Del Regno
2021-02-08 18:22 ` Stephen Boyd
2021-02-08 18:24 ` Stephen Boyd
2021-02-09 13:18 ` AngeloGioacchino Del Regno
2021-01-14 22:12 ` [PATCH v2 00/11] Clock fixes for MSM8998 GCC, MMCC, GPUCC AngeloGioacchino Del Regno
2021-01-30 17:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae79cc3-f857-d39e-5257-c6aa263eaf07@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).