From: Thara Gopinath <thara.gopinath@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
sboyd@kernel.org, mturquette@baylibre.com,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [Patch v2 6/6] dt-bindings: crypto: qcom-qce: Add v5.4 to binding
Date: Sat, 12 Dec 2020 10:25:16 -0500 [thread overview]
Message-ID: <f1babcb8-6017-dd3b-cbb6-9b4334037069@linaro.org> (raw)
In-Reply-To: <20201207220909.GA918596@robh.at.kernel.org>
On 12/7/20 5:09 PM, Rob Herring wrote:
> On Thu, Nov 19, 2020 at 10:52:33AM -0500, Thara Gopinath wrote:
>> Add compatible string to support v5.4 crypto engine.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
>> index fdd53b184ba8..ed1ede9c0acc 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt
>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
>> @@ -2,7 +2,9 @@ Qualcomm crypto engine driver
>>
>> Required properties:
>>
>> -- compatible : should be "qcom,crypto-v5.1"
>> +- compatible : should be
>> + "qcom,crypto-v5.1" for ipq6018
>> + "qcom,crypto-v5.4" for sdm845
>
> An outstanding example of why to use SoC specific compatibles rather
> than versions. Keep v5.1, but use SoC compatibles going forward.
Hi Rob,
Thanks for the review. We have different Soc's using the same version of
the ip. Is it okay to have "qcom,sdm845-crypto", "qcom,crypto-v5.4" amd
have only "qcom,crypto-<version>" in the driver ?
>
>> - reg : specifies base physical address and size of the registers map
>> - clocks : phandle to clock-controller plus clock-specifier pair
>> - clock-names : "iface" clocks register interface
>> --
>> 2.25.1
>>
--
Warm Regards
Thara
next prev parent reply other threads:[~2020-12-12 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:52 [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845 Thara Gopinath
2020-11-19 15:52 ` [Patch v2 1/6] dt-bindings: clock: Add entry for crypto engine RPMH clock resource Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 2/6] clk: qcom: rpmh: Add CE clock on sdm845 Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 3/6] drivers: crypto: qce: Enable support for crypto engine " Thara Gopinath
2020-11-19 15:52 ` [Patch v2 4/6] drivers: crypto: qce: Fix SHA result buffer corruption issues Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 5/6] dts: qcom: sdm845: Add dt entries to support crypto engine Thara Gopinath
2020-11-19 15:52 ` [Patch v2 6/6] dt-bindings: crypto: qcom-qce: Add v5.4 to binding Thara Gopinath
2020-12-07 22:09 ` Rob Herring
2020-12-12 15:25 ` Thara Gopinath [this message]
2020-11-19 22:44 ` [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845 Eric Biggers
2020-11-24 2:42 ` Thara Gopinath
2020-11-27 6:25 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1babcb8-6017-dd3b-cbb6-9b4334037069@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).