From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
mperttunen@nvidia.com, gregkh@linuxfoundation.org,
sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, spujar@nvidia.com,
josephl@nvidia.com, daniel.lezcano@linaro.org,
mmaddireddy@nvidia.com, markz@nvidia.com,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 15/19] ARM: dts: tegra: Add clock-cells property to pmc
Date: Thu, 19 Dec 2019 00:36:03 +0300 [thread overview]
Message-ID: <f9ccf209-e539-2ddc-cdcc-29cdb5749fae@gmail.com> (raw)
In-Reply-To: <1576613046-17159-16-git-send-email-skomatineni@nvidia.com>
17.12.2019 23:04, Sowjanya Komatineni пишет:
> Tegra PMC has clk_out_1, clk_out_2, clk_out_3, and blink clock.
>
> These clocks are moved from clock driver to pmc driver with pmc
> as the clock provider for these clocks.
>
> This patch adds #clock-cells property with 1 clock specifier to
> the Tegra PMC node in device tree.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> arch/arm/boot/dts/tegra114.dtsi | 4 +++-
> arch/arm/boot/dts/tegra124.dtsi | 4 +++-
> arch/arm/boot/dts/tegra20.dtsi | 4 +++-
> arch/arm/boot/dts/tegra30.dtsi | 4 +++-
> 4 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index 0d7a6327e404..b8f12f24f314 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/memory/tegra114-mc.h>
> #include <dt-bindings/pinctrl/pinctrl-tegra.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/tegra-pmc.h>
>
> / {
> compatible = "nvidia,tegra114";
> @@ -514,11 +515,12 @@
> status = "disabled";
> };
>
> - pmc@7000e400 {
> + pmc: pmc@7000e400 {
> compatible = "nvidia,tegra114-pmc";
> reg = <0x7000e400 0x400>;
> clocks = <&tegra_car TEGRA114_CLK_PCLK>, <&clk32k_in>;
> clock-names = "pclk", "clk32k_in";
> + #clock-cells = <1>;
> };
>
> fuse@7000f800 {
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 413bfb981de8..d0802c4ae3bf 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -6,6 +6,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/tegra124-car.h>
> #include <dt-bindings/thermal/tegra124-soctherm.h>
> +#include <dt-bindings/soc/tegra-pmc.h>
>
> / {
> compatible = "nvidia,tegra124";
> @@ -595,11 +596,12 @@
> clocks = <&tegra_car TEGRA124_CLK_RTC>;
> };
>
> - pmc@7000e400 {
> + pmc: pmc@7000e400 {
> compatible = "nvidia,tegra124-pmc";
> reg = <0x0 0x7000e400 0x0 0x400>;
> clocks = <&tegra_car TEGRA124_CLK_PCLK>, <&clk32k_in>;
> clock-names = "pclk", "clk32k_in";
> + #clock-cells = <1>;
> };
>
> fuse@7000f800 {
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 9c58e7fcf5c0..85a64747bec6 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/memory/tegra20-mc.h>
> #include <dt-bindings/pinctrl/pinctrl-tegra.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/tegra-pmc.h>
>
> / {
> compatible = "nvidia,tegra20";
> @@ -608,11 +609,12 @@
> status = "disabled";
> };
>
> - pmc@7000e400 {
> + pmc: pmc@7000e400 {
> compatible = "nvidia,tegra20-pmc";
> reg = <0x7000e400 0x400>;
> clocks = <&tegra_car TEGRA20_CLK_PCLK>, <&clk32k_in>;
> clock-names = "pclk", "clk32k_in";
> + #clock-cells = <1>;
> };
>
> mc: memory-controller@7000f000 {
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 55ae050042ce..4d5e9d0001d3 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/memory/tegra30-mc.h>
> #include <dt-bindings/pinctrl/pinctrl-tegra.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/tegra-pmc.h>
>
> / {
> compatible = "nvidia,tegra30";
> @@ -714,11 +715,12 @@
> status = "disabled";
> };
>
> - pmc@7000e400 {
> + pmc: pmc@7000e400 {
I think will be a bit better to name the phandle as "tegra_pmc", it has
the same vibe as the "tegra_car".
> compatible = "nvidia,tegra30-pmc";
> reg = <0x7000e400 0x400>;
> clocks = <&tegra_car TEGRA30_CLK_PCLK>, <&clk32k_in>;
> clock-names = "pclk", "clk32k_in";
> + #clock-cells = <1>;
> };
>
> mc: memory-controller@7000f000 {
>
next prev parent reply other threads:[~2019-12-18 21:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 20:03 [PATCH v4 00/19] Move PMC clocks into Tegra PMC driver Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 01/19] dt-bindings: clock: tegra: Change CLK_M_DIV to OSC_DIV clocks Sowjanya Komatineni
2019-12-18 21:19 ` Rob Herring
2019-12-17 20:03 ` [PATCH v4 02/19] clk: tegra: Change CLK_M_DIV clocks " Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 03/19] clk: tegra: Fix Tegra PMC clock out parents Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 04/19] dt-bindings: tegra: Convert Tegra PMC bindings to YAML Sowjanya Komatineni
2019-12-18 21:29 ` Rob Herring
2019-12-18 22:31 ` Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 05/19] dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings Sowjanya Komatineni
2019-12-18 7:56 ` Dmitry Osipenko
2019-12-17 20:03 ` [PATCH v4 06/19] soc: tegra: Add Tegra PMC clock registrations into PMC driver Sowjanya Komatineni
2019-12-18 8:30 ` Dmitry Osipenko
2019-12-18 8:35 ` Dmitry Osipenko
2019-12-18 15:46 ` Sowjanya Komatineni
2019-12-18 15:50 ` Sowjanya Komatineni
2019-12-18 16:52 ` Dmitry Osipenko
2019-12-18 17:00 ` Sowjanya Komatineni
2019-12-18 16:48 ` Dmitry Osipenko
2019-12-18 21:44 ` Dmitry Osipenko
2019-12-19 0:41 ` Sowjanya Komatineni
2019-12-20 1:21 ` Sowjanya Komatineni
2019-12-20 1:39 ` Dmitry Osipenko
2019-12-20 4:13 ` Sowjanya Komatineni
2019-12-20 4:34 ` Dmitry Osipenko
2019-12-20 19:06 ` Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 07/19] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC 32KHz blink clock Sowjanya Komatineni
2019-12-18 21:30 ` Rob Herring
2019-12-17 20:03 ` [PATCH v4 08/19] soc: tegra: Add support for " Sowjanya Komatineni
2019-12-18 5:08 ` Dmitry Osipenko
2019-12-17 20:03 ` [PATCH v4 09/19] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 10/19] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings Sowjanya Komatineni
2019-12-18 21:32 ` Rob Herring
2019-12-17 20:03 ` [PATCH v4 11/19] ASoC: tegra: Use device managed resource APIs to get the clock Sowjanya Komatineni
2019-12-17 20:03 ` [PATCH v4 12/19] ASoC: tegra: Add initial parent configuration for audio mclk Sowjanya Komatineni
2019-12-17 20:04 ` [PATCH v4 13/19] ASoC: tegra: Add fallback implementation " Sowjanya Komatineni
2019-12-18 6:59 ` Dmitry Osipenko
2019-12-18 7:01 ` Dmitry Osipenko
2019-12-18 7:14 ` Sowjanya Komatineni
2019-12-18 7:22 ` Dmitry Osipenko
2019-12-18 7:31 ` Dmitry Osipenko
2019-12-18 15:43 ` Sowjanya Komatineni
2019-12-18 16:29 ` Dmitry Osipenko
2019-12-18 16:32 ` Sowjanya Komatineni
2019-12-18 16:34 ` Dmitry Osipenko
2019-12-17 20:04 ` [PATCH v4 14/19] clk: tegra: Remove audio related clock enables from clocks init_table Sowjanya Komatineni
2019-12-17 20:04 ` [PATCH v4 15/19] ARM: dts: tegra: Add clock-cells property to pmc Sowjanya Komatineni
2019-12-18 21:36 ` Dmitry Osipenko [this message]
2019-12-17 20:04 ` [PATCH v4 16/19] arm64: tegra: Add clock-cells property to Tegra PMC node Sowjanya Komatineni
2019-12-17 20:04 ` [PATCH v4 17/19] ARM: tegra: Update sound node clocks in device tree Sowjanya Komatineni
2019-12-18 6:39 ` Dmitry Osipenko
2019-12-18 7:47 ` Dmitry Osipenko
2019-12-17 20:04 ` [PATCH v4 18/19] arm64: tegra: smaug: Change clk_out_2 provider to pmc Sowjanya Komatineni
2019-12-17 20:04 ` [PATCH v4 19/19] ASoC: nau8825: change Tegra clk_out_2 provider from tegra_car " Sowjanya Komatineni
2019-12-18 21:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9ccf209-e539-2ddc-cdcc-29cdb5749fae@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=markz@nvidia.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).