From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, narmstrong@baylibre.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: linux-clk@vger.kernel.org, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com,
mark.rutland@arm.com
Subject: Re: [RESEND PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB"
Date: Wed, 13 Feb 2019 09:40:33 +0100 [thread overview]
Message-ID: <fc50a3a7f1efc8d2f6054a944848897ed8baf536.camel@baylibre.com> (raw)
In-Reply-To: <20190210222603.6404-1-martin.blumenstingl@googlemail.com>
On Sun, 2019-02-10 at 23:26 +0100, Martin Blumenstingl wrote:
> It turns out that I'm not good at spelling "APB". Unfortunately an ABP
> (instead of APB) typo snug into two clocks in v5.0.
>
> Currently there are no users of that clock yet, so fix it now
> before it's too late (meaning before it's used by <something>).
>
> I decided to go the "normal" route where we can have separate
> branches for the dt-bindings and the drivers in the clk-meson
> repo. This means:
> - new (typo-free) clock #define
> - change the clock controller to use the new #define
> - (next development cycle) drop the old #define
>
> resend - changes since v2 at [1]:
> - include the device-tree maintainers / mailing list
>
> Changes since v1 at [0]:
> - split into a dt-bindings and clock controller driver patch
>
>
> [0] https://patchwork.kernel.org/cover/10742001/
> [1] https://patchwork.kernel.org/cover/10772199/
>
>
> Martin Blumenstingl (2):
> dt-bindings: clock: meson8b: add APB clock definition
> clk: meson: meson8b: fix the naming of the APB clocks
>
> drivers/clk/meson/meson8b.c | 26 ++++++++++++------------
> drivers/clk/meson/meson8b.h | 2 +-
> include/dt-bindings/clock/meson8b-clkc.h | 1 +
> 3 files changed, 15 insertions(+), 14 deletions(-)
>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
next prev parent reply other threads:[~2019-02-13 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 22:26 [RESEND PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB" Martin Blumenstingl
2019-02-10 22:26 ` [RESEND PATCH v2 1/2] dt-bindings: clock: meson8b: add APB clock definition Martin Blumenstingl
2019-02-10 22:26 ` [RESEND PATCH v2 2/2] clk: meson: meson8b: fix the naming of the APB clocks Martin Blumenstingl
2019-02-13 8:40 ` Jerome Brunet [this message]
2019-02-13 9:00 ` [RESEND PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB" Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc50a3a7f1efc8d2f6054a944848897ed8baf536.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).