From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: kernel@collabora.com,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Miles Chen <miles.chen@mediatek.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 0/5] Enable decoder for mt8183
Date: Mon, 12 Jun 2023 11:53:51 +0200 [thread overview]
Message-ID: <fda4f196-8466-8290-9072-d80fff367720@collabora.com> (raw)
In-Reply-To: <380c6489-7a3c-778b-5b81-6339b6964b90@xs4all.nl>
Il 12/06/23 09:02, Hans Verkuil ha scritto:
> Hi Nicolas,
>
> On 07/06/2023 22:53, Nícolas F. R. A. Prado wrote:
>>
>> This series enables the hardware decoder present on mt8183. At first
>> glance, the only missing piece is the devicetree node for it, however,
>> simply adding it as is would cause an address collision between the
>> first register iospace and the clock-controller node, so a rework of the
>> dt-binding and driver, as well as addition of a clock, were needed
>> first.
>>
>> Tested that H264 decoding works with the hardware decoder on
>> mt8183-kukui-jacuzzi-juniper-sku16, giving a fluster score of 98/135 on
>> the JVT-AVC_V1 test suite. And ensured other SoCs (MT8192 and MT8195)
>> still work as usual.
>>
>> Changes in v2:
>> - Merged commit 1 (media: dt-bindings: mediatek,vcodec: Allow single
>> clock for mt8183) into commit 3 (media: dt-bindings: mediatek,vcodec:
>> Remove VDEC_SYS for mt8183)
>> - Further constrained properties in dt-binding
>> - Added CLK_IGNORE_UNUSED flag to active clock
>> - Reformatted reg-names in DT node
>>
>> Nícolas F. R. A. Prado (4):
>> media: dt-bindings: mediatek,vcodec: Don't require assigned-clocks
>> media: dt-bindings: mediatek,vcodec: Remove VDEC_SYS for mt8183
>> media: mediatek: vcodec: Read HW active status from clock
>> clk: mediatek: mt8183: Add CLK_VDEC_ACTIVE to vdec
>
> Is the clk patch independent from the others? It's not clear to me.
>
> If the clk patch has to go in together with the media patches, then
> please let me know and post a v3 where the clk patch is also CC-ed to
> the linux-media mailinglist to ensure it ends up in our patchwork system.
>
> And in that case I need a Acked-by from the clk maintainer as well.
>
> If it is independent, then there is no need for a v3 (at least, not
> for this).
>
The clock patch is not independent, as in the devicetree changes will not
work without the addition of that clock (and of course even fail building),
so that series needs a v3.
Nícolas, please go on and send a v3 as requested.
Cheers,
Angelo
> Regards,
>
> Hans
>
>>
>> Yunfei Dong (1):
>> arm64: dts: mediatek: mt8183: Add decoder
>>
>> .../media/mediatek,vcodec-decoder.yaml | 65 +++++++++++++++----
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 30 +++++++++
>> drivers/clk/mediatek/clk-mt8183-vdec.c | 5 ++
>> .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 59 +++++++++++++----
>> .../mediatek/vcodec/mtk_vcodec_dec_hw.c | 20 ++++--
>> .../mediatek/vcodec/mtk_vcodec_dec_pm.c | 12 +++-
>> .../platform/mediatek/vcodec/mtk_vcodec_drv.h | 1 +
>> include/dt-bindings/clock/mt8183-clk.h | 3 +-
>> 8 files changed, 165 insertions(+), 30 deletions(-)
>>
>
>
next prev parent reply other threads:[~2023-06-12 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 20:53 [PATCH v2 0/5] Enable decoder for mt8183 Nícolas F. R. A. Prado
2023-06-07 20:53 ` [PATCH v2 4/5] clk: mediatek: mt8183: Add CLK_VDEC_ACTIVE to vdec Nícolas F. R. A. Prado
2023-06-08 7:34 ` AngeloGioacchino Del Regno
2023-06-08 7:43 ` Chen-Yu Tsai
2023-06-08 8:53 ` AngeloGioacchino Del Regno
2023-06-12 7:02 ` [PATCH v2 0/5] Enable decoder for mt8183 Hans Verkuil
2023-06-12 9:53 ` AngeloGioacchino Del Regno [this message]
2023-06-12 19:03 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda4f196-8466-8290-9072-d80fff367720@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=wenst@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).