From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206F817F for ; Tue, 29 Jun 2021 22:49:10 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 205A71FDDA; Tue, 29 Jun 2021 22:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625006943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlvM3MzcnkI5ct41kravAhdLb8Av6htcPQ3tAc07kmY=; b=ljGaQc3VJLB2w+oNaBigYEtTsLD44cQcnKzJcpRXjVEBNZYFQSo/UD03tJuQGjVqDjAOBQ VHiNzEz6QQwlFfyXQ7s6A0OkuLHup9KzDOeeNKE27lXp8Fep8m1fB0Ys3wMiOejDGjpD2D KTLlDkhxxtN/Yg2ggdLNeeie7zj8HX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625006943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlvM3MzcnkI5ct41kravAhdLb8Av6htcPQ3tAc07kmY=; b=/GpuesW/GrvcNHBpUkzkoLxs+SajReBCJCfO3O7+/BZJa3Bwcz2CTrNQI3Am/kHASYejbk jhE3+mC7JwujOVBQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 0DD2C11906; Tue, 29 Jun 2021 22:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625006943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlvM3MzcnkI5ct41kravAhdLb8Av6htcPQ3tAc07kmY=; b=ljGaQc3VJLB2w+oNaBigYEtTsLD44cQcnKzJcpRXjVEBNZYFQSo/UD03tJuQGjVqDjAOBQ VHiNzEz6QQwlFfyXQ7s6A0OkuLHup9KzDOeeNKE27lXp8Fep8m1fB0Ys3wMiOejDGjpD2D KTLlDkhxxtN/Yg2ggdLNeeie7zj8HX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625006943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlvM3MzcnkI5ct41kravAhdLb8Av6htcPQ3tAc07kmY=; b=/GpuesW/GrvcNHBpUkzkoLxs+SajReBCJCfO3O7+/BZJa3Bwcz2CTrNQI3Am/kHASYejbk jhE3+mC7JwujOVBQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id 47eGA1+j22A8XgAALh3uQQ (envelope-from ); Tue, 29 Jun 2021 22:49:03 +0000 Date: Wed, 30 Jun 2021 00:48:48 +0200 From: Borislav Petkov To: Dov Murik Cc: linux-efi@vger.kernel.org, Laszlo Ersek , Ashish Kalra , Brijesh Singh , Tom Lendacky , Ard Biesheuvel , James Morris , "Serge E. Hallyn" , Andi Kleen , "Dr. David Alan Gilbert" , James Bottomley , Tobin Feldman-Fitzthum , Jim Cadden , linux-coco@lists.linux.dev, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/3] virt: Add sev_secret module to expose confidential computing secrets Message-ID: References: <20210628183431.953934-1-dovmurik@linux.ibm.com> <20210628183431.953934-4-dovmurik@linux.ibm.com> <6e35f6db-9c5b-3c75-a66b-de1392295f6a@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6e35f6db-9c5b-3c75-a66b-de1392295f6a@linux.ibm.com> On Tue, Jun 29, 2021 at 10:23:49AM +0300, Dov Murik wrote: > But not if it's a generic driver that is useful for other confidential > computing implementations. Consider some non-encrypting guest memory > isolation mechanism where the host can't read most guest pages; this > module might be useful there too. Anything concrete or just hypothetical? In any case, if this thing is generic, it should not have "AMD" and "SEV" in the strings. > Also, isn't it a bit weird to depend on CONFIG_AMD_MEM_ENCRYPT but not > use any of its APIs? Yeah, see above. Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg