From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D0B6173 for ; Fri, 16 Jul 2021 20:26:03 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id j3so5880021plx.7 for ; Fri, 16 Jul 2021 13:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8tvSxeWjAmiPV1ecaOaeAqaw4ZJnCIRGxkWGCmBjbA8=; b=jIlbt7ooesOkOpbmts5nBhgs9jIU/SiAau352QIY0Hgeubf1kEbT+OcR/XjVd4kT+v 3fD8lV4szvIhxFXyM+uYYrQGWrg5wBxeuQ2S0VFf48AH+i4/ScDMvZ/wpqxl8XaLtWB1 5sBw774M3CLXtT+Vj+GS9UQahjyyarePM6P/ZXZBxsr54dQm0m5kpkcDppT69Py56TWs 57gCQFY57LOuhVvwhFAZTfqiyYlRvDo2aFfrRtqAV3Gj+D7CgmOqL2nfkKqI7gWSNwWP Evl25i5YTmPuqDf/s9LZtr9s03mx1pQcAG1vJ40a1kDU8OqGPXFnRlemxj0KkvtmTLYB bqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8tvSxeWjAmiPV1ecaOaeAqaw4ZJnCIRGxkWGCmBjbA8=; b=ttuLVOlq/+bBHw73PbUIh+H2z21qzELqNQDSh9Zf63UbO8dfyDbkmXJlsU6Av82q2I zMxC1HHi3r8n/r3WFuoKJWaZM6CrX50EmJ7x9CO7kMJwu2DMscOC+tYnHFQ9ZN5P4nVH rqpQq9+XUYjIPegYJXLyOSOPaTroQLAqKjg0GUZMXXGGXhuOWCSONZZPPKKqBqplIcpz Kr1dQSHHdyi8V93ztjdnSSFMA0RwxMsct+QiHXwD+e/XslvQjgINUmVj1eUZ3KH5wHdP JwCD4vCJQHw0PkYUWyMKiKQTh2A8IRnfvTfbsSaBIB63bdZjoKlTq/MJMakDgXb7lzrG x/Tg== X-Gm-Message-State: AOAM533kjKX0TSM9K6/bXgj1iOM88Kmj5kduScMhhfU4e8Om7hAQ2jFK WuM4UPliJcYTuyQQbc2QErM7ig== X-Google-Smtp-Source: ABdhPJyV16kybEQiRhFSioiQewGBf027oKkuUbSPAPg4nYD34PcD9PtL9JdNgcXLrSoQ1Ly4eisLjQ== X-Received: by 2002:a17:90a:4893:: with SMTP id b19mr11380703pjh.45.1626467162727; Fri, 16 Jul 2021 13:26:02 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id b15sm11895147pgm.15.2021.07.16.13.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 13:26:02 -0700 (PDT) Date: Fri, 16 Jul 2021 20:25:58 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 31/40] KVM: X86: update page-fault trace to log the 64-bit error code Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-32-brijesh.singh@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707183616.5620-32-brijesh.singh@amd.com> On Wed, Jul 07, 2021, Brijesh Singh wrote: > The page-fault error code is a 64-bit value, but the trace prints only It's worth clarifying that #NPT has a 64-bit error code, and so KVM also passes around a 64-bit PFEC. E.g. the above statement is wrong for legacy #PF. > the lower 32-bits. Some of the SEV-SNP RMP fault error codes are > available in the upper 32-bits. Can you send this separately with Cc: stable@? And I guess tweak the changelog to replace "SEV-SNP RMP" with a reference to e.g. PFERR_GUEST_FINAL_MASK. KVM already has error codes that can set the upper bits.