From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4139B2C83 for ; Mon, 15 Nov 2021 15:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636990389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=APBRR/Tu29EEMq5VPRu2UikpYWd3k5GAcRpc7iagv8Y=; b=iSq5dZ11iKlabDh5S81yAjysNZaK05j+T/3Db3PfuPoWHz+O2DDtCbLnJNoL5Bmm3bf+e3 PYnvmk2ruRsjVyrFhr6BCYnvHOx9eCpptvzazpmLTWqq1qwvhX6aHMj1O7ax00tAynE1DY t1MJZUC5uszmBAnOmVeBfxEJeB2nF/k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-ZR0R8xNcOTegLDlPyZB2ig-1; Mon, 15 Nov 2021 10:33:07 -0500 X-MC-Unique: ZR0R8xNcOTegLDlPyZB2ig-1 Received: by mail-wm1-f71.google.com with SMTP id o18-20020a05600c511200b00332fa17a02eso61890wms.5 for ; Mon, 15 Nov 2021 07:33:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=APBRR/Tu29EEMq5VPRu2UikpYWd3k5GAcRpc7iagv8Y=; b=GlNo0gU7lF8uvniOjVmsS4L0RUHolx7Mj0SAB5R5nuIwDkWWQOQVG62CygzZoI7dRl BqymNKhWgLGxW3T0K7B//tI2c99tMwMvNMzlwN5OSibTZWVgp+w117835ekwfetnfMOJ HAVtDtX5z+efPTRedOuSZE2Xodr8jRmk+TJQZ1AfIFV97Wo39aG1LqLofO4l9SoKfBBo ulkz0TaR9iKpV0jKYyZzDXmuU0K1YInOWRwpk/PLoAwfx/n/xGqU8CsKUmrr+IbO2Lzy Ex+P+ZhgQFfQaa83d3DE9/2o1LLHWIdV3M1OVldzZiPf60Ug91fiELv4+c8Ku4XA4lo+ pRzQ== X-Gm-Message-State: AOAM5326vG64GuUBzhZxna9Ua4nUN/5TK8PuimboDOH/Ja+xU4SAnocn nH4YfxvB9PGBM3bJme2BaaojwatbbhbQMZFrfH7JDQvfd+g+BwOzpE04qTDp4fuTxjtW6PC6PqA QHJhS/eF2rvZKUDBST6XSsg== X-Received: by 2002:a1c:f416:: with SMTP id z22mr3828180wma.121.1636990386549; Mon, 15 Nov 2021 07:33:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVEfAw7ZxqSyPXBoql05G+DuRg+Mia/ijEWI8l4vzLqLBTzBiaKW9nePq93987lkPciDsGDA== X-Received: by 2002:a1c:f416:: with SMTP id z22mr3828132wma.121.1636990386389; Mon, 15 Nov 2021 07:33:06 -0800 (PST) Received: from work-vm (cpc109025-salf6-2-0-cust480.10-2.cable.virginm.net. [82.30.61.225]) by smtp.gmail.com with ESMTPSA id t8sm17359470wmq.32.2021.11.15.07.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 07:33:05 -0800 (PST) Date: Mon, 15 Nov 2021 15:33:03 +0000 From: "Dr. David Alan Gilbert" To: Joerg Roedel Cc: Sean Christopherson , Borislav Petkov , Dave Hansen , Peter Gonda , Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH Part2 v5 00/45] Add AMD Secure Nested Paging (SEV-SNP) Hypervisor Support Message-ID: References: <20210820155918.7518-1-brijesh.singh@amd.com> <061ccd49-3b9f-d603-bafd-61a067c3f6fa@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Joerg Roedel (jroedel@suse.de) wrote: > On Mon, Nov 15, 2021 at 12:30:59PM +0000, Dr. David Alan Gilbert wrote: > > Still; I wonder if it's best to kill the guest - maybe it's best for > > the host to kill the guest and leave behind diagnostics of what > > happened; for someone debugging the crash, it's going to be less useful > > to know that page X was wrongly accessed (which is what the guest would > > see), and more useful to know that it was the kernel's vhost-... driver > > that accessed it. > > I is best to let the guest #VC on the page when this happens. If it > happened because of a guest bug all necessary debugging data is in the > guest and only the guest owner can obtain it. > > Then the guest owner can do a kdump on this unexpected #VC and collect > the data to debug the issue. With just killing the guest from the host > side this data would be lost. How would you debug an unexpected access by the host kernel using a guests kdump? Dave > Regards, > > Joerg > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK