From: David Daney <ddaney@caviumnetworks.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
George Cherian <george.cherian@cavium.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: David Daney <david.daney@cavium.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: cavium: fix Kconfig dependencies
Date: Tue, 14 Feb 2017 10:30:38 -0800 [thread overview]
Message-ID: <064ee39e-68f9-4726-ab64-3f460892340b@caviumnetworks.com> (raw)
In-Reply-To: <47441e97-99be-15e7-ea15-b35a4a827139@infradead.org>
On 02/14/2017 10:26 AM, Randy Dunlap wrote:
> On 02/14/17 09:09, David Daney wrote:
>> On 02/14/2017 09:07 AM, Arnd Bergmann wrote:
>>> The driver fails to build if MSI support is disabled:
>>>
>>> In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0:
>>> drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry'
>>> struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS];
>>> ^~~~~~~~~~~~
>>> drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix':
>>> drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration]
>>>
>>> On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER,
>>> so let's allow compile-testing to catch this kind of problem more easily.
>>> The 64-bit dependency is needed for the use of readq/writeq.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> drivers/crypto/cavium/cpt/Kconfig | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/crypto/cavium/cpt/Kconfig b/drivers/crypto/cavium/cpt/Kconfig
>>> index 247f1cbbefc1..cbd51b1aa046 100644
>>> --- a/drivers/crypto/cavium/cpt/Kconfig
>>> +++ b/drivers/crypto/cavium/cpt/Kconfig
>>> @@ -7,7 +7,8 @@ config CRYPTO_DEV_CPT
>>>
>>> config CAVIUM_CPT
>>> tristate "Cavium Cryptographic Accelerator driver"
>>> - depends on ARCH_THUNDER
>>> + depends on ARCH_THUNDER || COMPILE_TEST
>>> + depends on PCI_MSI && 64BIT
>>
>>
>> Perhaps we should select PCI and PCI_MSI instead.
>>
>> These systems cannot function without those.
>
> Then the "depends" (and hence the patch) is correct.
>
> A driver should not enable all of PCI if it is disabled
> for some other reason.
I see your point. In that case, this patch:
Acked-by: David Daney <david.daney@cavium.com>
>
>>> select CRYPTO_DEV_CPT
>>> help
>>> Support for Cavium CPT block found in octeon-tx series of
>>>
>>
>
>
next prev parent reply other threads:[~2017-02-14 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 17:07 [PATCH] crypto: cavium: fix Kconfig dependencies Arnd Bergmann
2017-02-14 17:09 ` David Daney
2017-02-14 18:26 ` Randy Dunlap
2017-02-14 18:30 ` David Daney [this message]
2017-02-15 5:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064ee39e-68f9-4726-ab64-3f460892340b@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=george.cherian@cavium.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).