linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: George Cherian <gcherian@caviumnetworks.com>
Cc: George Cherian <george.cherian@cavium.com>,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	david.daney@cavium.com, clabbe.montjoie@gmail.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT
Date: Wed, 11 Jan 2017 13:39:33 +0100	[thread overview]
Message-ID: <1522639.tMShRcNLPc@positron.chronox.de> (raw)
In-Reply-To: <587616D1.6050503@caviumnetworks.com>

Am Mittwoch, 11. Januar 2017, 16:58:17 CET schrieb George Cherian:

Hi George,

> I will add a seperate function for xts setkey and make changes as following.
> > ...
> > 
> >> +
> >> +struct crypto_alg algs[] = { {
> >> +	.cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC,
> >> +	.cra_blocksize = AES_BLOCK_SIZE,
> >> +	.cra_ctxsize = sizeof(struct cvm_enc_ctx),
> >> +	.cra_alignmask = 7,
> >> +	.cra_priority = 4001,
> >> +	.cra_name = "xts(aes)",
> >> +	.cra_driver_name = "cavium-xts-aes",
> >> +	.cra_type = &crypto_ablkcipher_type,
> >> +	.cra_u = {
> >> +		.ablkcipher = {
> >> +			.ivsize = AES_BLOCK_SIZE,
> >> +			.min_keysize = AES_MIN_KEY_SIZE,
> >> +			.max_keysize = AES_MAX_KEY_SIZE,
> >> +			.setkey = cvm_enc_dec_setkey,
> > 
> > May I ask how the setkey for XTS is intended to work? The XTS keys are
> > double in size than "normal" keys.
> 
> 		.ablkcipher = {
> 			.ivsize = AES_BLOCK_SIZE,
> 			.min_keysize = 2 * AES_MIN_KEY_SIZE,
> 			.max_keysize = 2 * AES_MAX_KEY_SIZE,
> 			.setkey = cvm_xts_setkey,
> 
> Hope this is fine?
> 
Sure, please do not forget to invoke xts_verify_key.

Ciao
Stephan

  reply	other threads:[~2017-01-11 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 10:56 [PATCH v4 0/3] Add Support for Cavium Cryptographic Acceleration Unit George Cherian
2017-01-11 10:56 ` [PATCH v4 1/3] drivers: crypto: Add Support for Octeon-tx CPT Engine George Cherian
2017-01-11 10:56 ` [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT George Cherian
2017-01-11 11:12   ` Stephan Müller
2017-01-11 11:28     ` George Cherian
2017-01-11 12:39       ` Stephan Müller [this message]
2017-01-12 11:10         ` George Cherian
2017-01-12 11:19           ` Stephan Müller
2017-01-12 11:20             ` George Cherian
2017-01-11 10:56 ` [PATCH v4 3/3] drivers: crypto: Enable CPT options crypto for build George Cherian
2017-01-12 12:40   ` kbuild test robot
2017-01-12 13:38   ` kbuild test robot
2017-01-12 13:38   ` [PATCH] drivers: crypto: fix ifnullfree.cocci warnings kbuild test robot
2017-01-12 14:04   ` [PATCH v4 3/3] drivers: crypto: Enable CPT options crypto for build kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522639.tMShRcNLPc@positron.chronox.de \
    --to=smueller@chronox.de \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.daney@cavium.com \
    --cc=gcherian@caviumnetworks.com \
    --cc=george.cherian@cavium.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).